Merge lp:~ev/uci-engine/missing-sst-dep into lp:uci-engine

Proposed by Evan
Status: Rejected
Rejected by: Evan
Proposed branch: lp:~ev/uci-engine/missing-sst-dep
Merge into: lp:uci-engine
Diff against target: 12 lines (+1/-1)
1 file modified
testing/ (+1/-1)
To merge this branch: bzr merge lp:~ev/uci-engine/missing-sst-dep
Reviewer Review Type Date Requested Status
Celso Providelo (community) Needs Information
PS Jenkins bot (community) continuous-integration Approve
Review via email:

Commit message

Add missing sst dependency.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:902
Executed test runs:

Click here to trigger a rebuild:

review: Approve (continuous-integration)
Revision history for this message
Celso Providelo (cprov) wrote :


SST is already being installed as a dependency of ci_utils (see ci_utils/

I don't mind making it an additional (read only needed for testing) dependency, but the difference is not entirely clear to me.

review: Needs Information
Revision history for this message
Evan (ev) wrote :

Strange. Somehow I didn't end up with it installed. I'll chalk it up to my environment being slightly busted.

Unmerged revisions

902. By Evan

Add missing sst dependency.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'testing/'
2--- testing/ 2014-11-12 19:15:12 +0000
3+++ testing/ 2014-11-25 12:00:19 +0000
4@@ -107,7 +107,7 @@
6 def additional_deps():
7 '''Install addtional dependencies.'''
8- additional_deps = ['cheetah', 'python-apt', 'jinja2', 'statsd']
9+ additional_deps = ['cheetah', 'python-apt', 'jinja2', 'statsd', 'sst']
10 for dep in additional_deps:
11 cache_file = 'file://%s' % os.environ['PIP_CACHE']
12 cmd = ['pip', 'install', '--no-index', '-f', cache_file, dep]


People subscribed via source and target branches

to all changes: