Code review comment for lp:~ev/compiz/call-apport-on-hangs

Revision history for this message
Evan (ev) wrote :

On Wed, Jul 4, 2012 at 8:41 PM, Sam Spilsbury
<email address hidden> wrote:
> Also, some indentation notes:
>
> 72 + app = wnck_window_get_application (win);
> 73 + if (!app)
> 74 + return FALSE;
>
> You need a one-tab indent for the return FALSE;
>
> 76 + pid = wnck_application_get_pid (app);
> 77 + if (d->apport_dialog) {
> 78 + /* Is Apport already running? */
> 79 + if (kill (d->apport_dialog, 0) >= 0 && errno != ESRCH)
> 80 + return TRUE;
> 81 + }
>
> pid is indented incorrectly, the brace should fall on the next line, return TRUE needs an indent (4 spaces)

Does compiz mix tabs and spaces? If so, why?

Also, is there a codified coding style to be followed?

« Back to merge proposal