Merge lp:~ev/apport/raring-suid_dumpable into lp:~ubuntu-core-dev/ubuntu/raring/apport/ubuntu

[Evan]

This branch enables core dumps for suid binaries.

This has traditionally been off by default due to concerns over possible security vulnerabilities. Kees has looked into this and protected against the case where the core pipe handler is set to "core" and setuid_dumpable is set:

[21:41:54] <kees> it's safe to do suidcoredump=2 thing now, too.
[21:42:37] <kees> er, fs.suid_dumpable=2 rather
[21:43:00] <kees> that was a fun fix, inspired by some discussion with ev a while back...

http://kernel.ubuntu.com/git?p=ubuntu/ubuntu-raring.git;a=blob;f=Documentation/sysctl/fs.txt;h=88152f214f48cb69c643d4bf2ff2ac9a61ad2eb0;hb=HEAD

I would like to backport this apport change to previous Ubuntu releases, with your permission.

[Martin Pitt (pitti)]

This looks good to me, provided that we merge it into saucy (first). But please fix the indentation in the stop part.

Thanks!

review: Approve

[Evan (ev)]

Just to confirm:

evan@poppy-dev ~
  % cat /proc/sys/fs/suid_dumpable
2

evan@poppy-dev ~
  % sudo kill -SEGV 3580
[sudo] password for evan:

evan@poppy-dev ~
  % ls -la /var/crash
total 9044
drwxrwsrwt 2 root whoopsie 4096 Jun 25 15:26 .
drwxr-xr-x 17 root root 4096 May 14 16:08 ..
-rw-rw---- 1 root whoopsie 0 Jun 25 15:26 .lock
-rw-r----- 1 whoopsie whoopsie 377582 Jun 25 15:26 _usr_bin_whoopsie.115.crash

[Martin Pitt (pitti)]

But /usr/bin/whoopsie isn't suid, so this doesn't say much?

[Evan (ev)]

Yup, my bad. I confused +s for setreuid(). I've retried with passwd and confirmed it to work.

[lp:~ev/apport/raring-suid_dumpable]

2186. By Evan on 2013-06-25

Use a tab.