Merge lp:~ev/apport/1205608 into lp:~apport-hackers/apport/trunk

[Evan]

Fixes a crash when you specify a sandbox but not a cache.

[Martin Pitt (pitti)]

Just a quick review, I'm on my way out.

We create a temporary cache if the user doesn't specify one, so we should rather fix the logic to use that then. It shouldn't be mandatory to use a permanent cache; in fact it's quite redundant with doing stuff on /tmp/ on a tmpfs and having apt-cacher-ng (I have that).

review: Needs Fixing

[Martin Pitt (pitti)]

Please note that in the report the user didn't actually use a sandbox. His command (apport-retrace -s xxx.crash) works fine on current trunk now. I can reproduce the crash with -S without -C, but that has a simple fix. So I'm closing this MP.

Thanks anyway!

review: Disapprove

[Evan (ev)]

Ah, apologies for that!

Unmerged revisions

2669. By Evan on 2013-07-29

* apport-retrace: disallow using a sandbox without a cache (LP: #1205608).

=== modified file 'NEWS'
--- NEWS	2013-07-23 04:58:15 +0000
+++ NEWS	2013-07-29 15:51:29 +0000
@@ -13,6 +13,7 @@
    together, and give a proper error message in this case. (LP: #1071905)
  * apport: Fix "Exectuable" typo, leading to reports not being synced on
    upstart crashes. Thanks James Hunt. (LP: #1203744)
+ * apport-retrace: disallow using a sandbox without a cache (LP: #1205608).
 
 2.11 (2013-07-17)
 -----------------

=== modified file 'bin/apport-retrace'
--- bin/apport-retrace	2013-01-07 20:39:20 +0000
+++ bin/apport-retrace	2013-07-29 15:51:29 +0000
@@ -72,8 +72,8 @@
 
     # catch invalid usage of -C without -S (cache is only used when making a
     # sandbox)
-    if opts.cache and not opts.sandbox:
-        optparser.error(_('You cannot use -C without -S. Stopping.'))
+    if (opts.cache and not opts.sandbox) or (opts.sandbox and not opts.cache):
+        optparser.error(_('You cannot use -C without -S or vice versa. Stopping.'))
         sys.exit(1)
 
     if not (opts.auth or opts.output or opts.stdout or opts.gdb):