adt-cloud-worker

Merge lp:~ev/adt-cloud-worker/support-virtualenv into lp:adt-cloud-worker

  1. support-virtualenv
  2. Merge into trunk
Proposed by Evan
Status: Merged
Merged at revision: 6
Proposed branch: lp:~ev/adt-cloud-worker/support-virtualenv
Merge into: lp:adt-cloud-worker
Diff against target: 9 lines (+1/-1)
1 file modified
adt-cloud-worker.py (+1/-1)
To merge this branch: bzr merge lp:~ev/adt-cloud-worker/support-virtualenv
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Para Siva (community) Approve
Review via email: mp+251587@code.launchpad.net

Commit message

Call python via env, to support virtualenv.

To post a comment you must log in.
Revision history for this message
Para Siva (psivaa) wrote :

+1

review: Approve
Revision history for this message
Celso Providelo (cprov) wrote :

We certainly can add venv support, since it's simple, but bear in mind that we are still only depending on deb packages (python3-kombu was backported to trusty) and I think much easier and better security-wise to avoid deploying pip.

Maybe there is room for developing with pip, but the versions already diverge and I am resistant to cover it in documentation instead of simply `apt-get install [deps]`.

Not a blocker to this MP, though.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'adt-cloud-worker.py'
2--- adt-cloud-worker.py 2015-03-03 02:15:49 +0000
3+++ adt-cloud-worker.py 2015-03-03 12:17:24 +0000
4@@ -1,4 +1,4 @@
5-#!/usr/bin/python3
6+#!/usr/bin/env python3
7
8 # adt-cloud-worker
9 # Copyright (C) 2015 Canonical

Subscribers

People subscribed via source and target branches

to all changes: