Merge lp:~eugenesan/ppa-purge/trunk into lp:ppa-purge
Proposed by
Eugene San
Status: | Superseded |
---|---|
Proposed branch: | lp:~eugenesan/ppa-purge/trunk |
Merge into: | lp:ppa-purge |
Diff against target: |
149 lines (+47/-36) 3 files modified
debian/changelog (+8/-0) debian/control (+1/-1) ppa-purge (+38/-35) |
To merge this branch: | bzr merge lp:~eugenesan/ppa-purge/trunk |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
ppa-purge | Pending | ||
Review via email: mp+46570@code.launchpad.net |
This proposal has been superseded by a proposal from 2011-01-18.
Description of the change
Adding support for compressed and empty packages lists
To post a comment you must log in.
Unmerged revisions
- 61. By Eugene San
-
Update debian/changelog
- 60. By Eugene San
-
Fixng failed empty list detection
- 59. By Eugene San
-
Fixing nonblocking typos
- 58. By Eugene San
-
Finalizing support for compressed and empty apt lists
- 57. By Eugene San
-
Merged main branch
- 56. By Eugene San
-
Adding support for compressed and empty packages lists
- 55. By eugenesan <eugenesan@portsan>
-
Fixing typo in changelog
- 54. By eugenesan <eugenesan@portsan>
-
Fixing typo causing permanent aptitude usage
- 53. By eugenesan <eugenesan@portsan>
-
Few changes for upcoming 0.2.8
- 52. By eugenesan <eugenesan@portsan>
-
Adding reverse order of apt tool usage and support for symlinked lists
Hi, thanks for the code. This could also have been three commits though: 1) whitespace clean-up, 2) adding support for compressed package lists, 3) add support for empty package lists.
Anyway, does it really work? $LIST is always an existing file (as long as the * in PPA_LIST successfully expands, otherwise it is useless, that was what the original -e checked for), so 1) the elif's can not be reached and 2) $LIST.gz can not exist at the same time as $LIST, right? I don't have any compressed lists on my machine so I can not verify this case :)
Basically, 1) the PPA_LIST does not match anything ending in .gz etc, and 2) if it would, $LIST.gz would not exist since the .gz would already be included in $LIST.
I can suggest instead adding * to the end of the PPA_LIST so that any filename suffix gets expanded, then use lesspipe to decompress $LIST whatever its file type is (kind of a hack).