Merge lp:~etulfetulf/software-properties/software-properties-fix-916982 into lp:software-properties

Proposed by Greg A on 2012-04-12
Status: Rejected
Rejected by: Brian Murray on 2012-04-19
Proposed branch: lp:~etulfetulf/software-properties/software-properties-fix-916982
Merge into: lp:software-properties
Diff against target: 12 lines (+1/-1)
1 file modified
data/software-properties-gtk.desktop.in (+1/-1)
To merge this branch: bzr merge lp:~etulfetulf/software-properties/software-properties-fix-916982
Reviewer Review Type Date Requested Status
Greg A (community) Resubmit on 2012-04-21
Brian Murray 2012-04-12 Disapprove on 2012-04-19
Review via email: mp+101757@code.launchpad.net
To post a comment you must log in.
Brian Murray (brian-murray) wrote :

A deliberate change was made by the desktop team to hide software-properties-gtk as it can be accessed from update-manager and software-center. You can learn more about this change in the specification at https://blueprints.launchpad.net/ubuntu/+spec/desktop-p-control-center-cleanup and perhaps in the following diff http://launchpadlibrarian.net/89584324/software-properties_0.82_0.82.2.diff.gz.

For future reference, it would have been good to include a changelog entry, in debian/changelog, documenting the change you made and why. You can easily add a changelog entry using the command dch -i.

review: Disapprove
Greg A (etulfetulf) wrote :

I understand that the decision was made to remove Software Properties from System Settings (this is discussed in the blueprint).

However, this branch is about a separate matter: allowing Software Properties to appear in the Dash search (as discussed in Bug 916982).

For this reason, I would ask you to reconsider this merge.

review: Resubmit

Unmerged revisions

753. By Greg A on 2012-04-21

Add changelog entry

752. By Greg A on 2012-04-12

Allow Software Sources to show in Unity dash (LP: #916982)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/software-properties-gtk.desktop.in'
2--- data/software-properties-gtk.desktop.in 2012-01-11 16:19:47 +0000
3+++ data/software-properties-gtk.desktop.in 2012-04-12 15:47:43 +0000
4@@ -5,7 +5,7 @@
5 Exec=software-properties-gtk
6 Icon=software-properties
7 Terminal=false
8-NoDisplay=true
9+NoDisplay=false
10 X-MultipleArgs=false
11 Type=Application
12 Categories=GNOME;GTK;Settings;X-GNOME-SystemSettings;

Subscribers

People subscribed via source and target branches

to status/vote changes: