Merge ~esunar/charm-nrpe:fix-functional-tests-bseng-1095 into charm-nrpe:master

Proposed by Erhan Sunar
Status: Merged
Merged at revision: d58a495d662d806245aa46f5b114d0e00a47406e
Proposed branch: ~esunar/charm-nrpe:fix-functional-tests-bseng-1095
Merge into: charm-nrpe:master
Diff against target: 14 lines (+3/-0)
1 file modified
tests/functional/tests/bundles/base.yaml (+3/-0)
Reviewer Review Type Date Requested Status
Robert Gildein Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Sudeep Bhandari Pending
JamesLin Pending
Erhan Sunar Pending
BootStack Reviewers Pending
BootStack Reviewers Pending
Review via email: mp+441245@code.launchpad.net

Commit message

Fix for bseng-1095

Adding storage support to ubuntu charm prevented
deployment of ubuntu charm on lxd. Thus it is reverted
to revision 21 to be able to run functional tests.

Related issue:
  https://github.com/juju-solutions/charm-ubuntu/issues/48

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :
review: Approve (continuous-integration)
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Failed to merge change (no changes to merge), setting status to needs review.

Revision history for this message
Robert Gildein (rgildein) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/tests/functional/tests/bundles/base.yaml b/tests/functional/tests/bundles/base.yaml
2index c01fa2e..c8983d8 100644
3--- a/tests/functional/tests/bundles/base.yaml
4+++ b/tests/functional/tests/bundles/base.yaml
5@@ -6,6 +6,9 @@ applications:
6 constraints: root-disk=8G cores=2
7 container:
8 charm: ch:ubuntu
9+ # temporary fix for https://github.com/juju-solutions/charm-ubuntu/issues/48
10+ revision: 21
11+ channel: stable
12 num_units: 1
13 to: ["lxd:rabbitmq-server/0"]
14 nagios:

Subscribers

People subscribed via source and target branches

to all changes: