Merge lp:~ericsnowcurrently/landscape-bundles/drop-rendered-source into lp:landscape-bundles

Proposed by Eric Snow
Status: Merged
Approved by: Eric Snow
Approved revision: 39
Merged at revision: 38
Proposed branch: lp:~ericsnowcurrently/landscape-bundles/drop-rendered-source
Merge into: lp:landscape-bundles
Diff against target: 31 lines (+4/-2)
2 files modified
Makefile (+2/-2)
landscape-template.jinja2 (+2/-0)
To merge this branch: bzr merge lp:~ericsnowcurrently/landscape-bundles/drop-rendered-source
Reviewer Review Type Date Requested Status
Adam Collard (community) Approve
Chad Smith Approve
🤖 Landscape Builder test results Approve
Review via email: mp+321311@code.launchpad.net

Commit message

Do not set an empty "source" field in the rendered bundle.

Apparently Juju chokes when the source field is empty.

Description of the change

Do not set an empty "source" field in the rendered bundle.

Apparently Juju chokes when the source field is empty.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :
review: Approve (test results)
Revision history for this message
Chad Smith (chad.smith) wrote :

+1 on this changeset

review: Approve
Revision history for this message
Adam Collard (adam-collard) wrote :

LGTM +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Makefile'
2--- Makefile 2017-03-27 22:12:34 +0000
3+++ Makefile 2017-03-29 15:19:53 +0000
4@@ -14,11 +14,11 @@
5 ./charm-store publish-latest ${CHARM_STORE_USER} ${CHANNEL}
6
7 .PHONY: render
8-render: deps clean
9+render: clean
10 @./render-bundles
11
12 .PHONY: update-charm-revisions
13-update-charm-revisions: deps
14+update-charm-revisions:
15 @./update-charm-revisions \
16 $(EXTRA_UPDATE_ARGUMENTS) \
17 postgresql haproxy rabbitmq-server
18
19=== modified file 'landscape-template.jinja2'
20--- landscape-template.jinja2 2017-03-16 17:37:29 +0000
21+++ landscape-template.jinja2 2017-03-29 15:19:53 +0000
22@@ -81,7 +81,9 @@
23 {% endif %}
24 num_units: 1
25 options:
26+ {% if landscape["source"] %}
27 source: {{ landscape["source"] }}
28+ {% endif %}
29 key: {{ landscape["key"] }}
30 {% if landscape["ssl-cert"] %}
31 ssl-cert: {{ landscape["ssl-cert"] }}

Subscribers

People subscribed via source and target branches

to all changes: