Fake Juju

Merge lp:~ericsnowcurrently/fake-juju/fix-api-host-ports into lp:~landscape/fake-juju/trunk-old

  1. fix-api-host-ports
  2. Merge into trunk-old
Proposed by Eric Snow
Status: Merged
Approved by: Eric Snow
Approved revision: 48
Merged at revision: 48
Proposed branch: lp:~ericsnowcurrently/fake-juju/fix-api-host-ports
Merge into: lp:~landscape/fake-juju/trunk-old
Diff against target: 10 lines (+1/-0)
1 file modified
2.0.0/fake-juju.go (+1/-0)
To merge this branch: bzr merge lp:~ericsnowcurrently/fake-juju/fix-api-host-ports
Reviewer Review Type Date Requested Status
Chad Smith Approve
Alberto Donato (community) Approve
🤖 Landscape Builder test results Approve
Review via email: mp+309797@code.launchpad.net

Commit message

Set the proper network space name.

txjuju special-cases a certain network space name for the sake of
fake-juju. This change makes use of that.

Description of the change

Set the proper network space name.

txjuju special-cases a certain network space name for the sake of
fake-juju. This change makes use of that.

To post a comment you must log in.
Revision history for this message
🤖 Landscape Builder (landscape-builder) :
review: Abstain (executing tests)
Revision history for this message
🤖 Landscape Builder (landscape-builder) wrote :

Command: make ci-test
Result: Success
Revno: 48
Branch: lp:~ericsnowcurrently/fake-juju/fix-api-host-ports
Jenkins: https://ci.lscape.net/job/latch-test-xenial/936/

review: Approve (test results)
Revision history for this message
Alberto Donato (ack) wrote :

+1, LGTM

review: Approve
Revision history for this message
Chad Smith (chad.smith) wrote :

+1 here

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '2.0.0/fake-juju.go'
2--- 2.0.0/fake-juju.go 2016-10-27 03:45:46 +0000
3+++ 2.0.0/fake-juju.go 2016-11-01 20:40:38 +0000
4@@ -573,6 +573,7 @@
5 s.toCloseOnTearDown = append(s.toCloseOnTearDown, logFile, jujudLogFile)
6
7 ports := s.APIState.APIHostPorts()
8+ ports[0][0].SpaceName = "dummy-provider-network"
9 err := s.State.SetAPIHostPorts(ports)
10 c.Assert(err, gc.IsNil)
11

Subscribers

People subscribed via source and target branches

to all changes: