Merge lp:~eres/gcc-linaro/sms_move_creation_anti-dep_edge into lp:gcc-linaro/4.5

Proposed by Revital Eres
Status: Merged
Approved by: Ulrich Weigand
Approved revision: no longer in the source branch.
Merged at revision: 99534
Proposed branch: lp:~eres/gcc-linaro/sms_move_creation_anti-dep_edge
Merge into: lp:gcc-linaro/4.5
Diff against target: 45 lines (+14/-6)
2 files modified
ChangeLog.linaro (+10/-0)
gcc/ddg.c (+4/-6)
To merge this branch: bzr merge lp:~eres/gcc-linaro/sms_move_creation_anti-dep_edge
Reviewer Review Type Date Requested Status
Ulrich Weigand (community) Approve
Review via email: mp+69923@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild has taken a snapshot of this branch at r99531 and queued it for build.

The snapshot is available at:
 http://ex.seabright.co.nz/snapshots/gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge.tar.xdelta3.xz

and will be built on the following builders:

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge
cbuild-ancestor: lp:gcc-linaro+bzr99530
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote :

Poking the build system...

cbuild-state: queue

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild has taken a snapshot of this branch at r99531 and queued it for build.

The snapshot is available at:
 http://ex.seabright.co.nz/snapshots/gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge.tar.xdelta3.xz

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge
cbuild-ancestor: lp:gcc-linaro+bzr99530
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild159-ursa2-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge/logs/armv7l-natty-cbuild159-ursa2-cortexa9r1

The testsuite results are the same as the branch point lp:gcc-linaro+bzr99530

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge/logs/armv7l-natty-cbuild159-ursa2-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild159-ursa2-cortexa9r1

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild159-ursa4-armv5r2.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge/logs/armv7l-natty-cbuild159-ursa4-armv5r2

The testsuite results are the same as the branch point lp:gcc-linaro+bzr99530

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge/logs/armv7l-natty-cbuild159-ursa4-armv5r2/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild159-ursa4-armv5r2

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on i686-natty-cbuild159-oort6-i686r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge/logs/i686-natty-cbuild159-oort6-i686r1

The testsuite results are the same as the branch point lp:gcc-linaro+bzr99530

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge/logs/i686-natty-cbuild159-oort6-i686r1/gcc-testsuite.txt

cbuild-checked: i686-natty-cbuild159-oort6-i686r1

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on x86_64-natty-cbuild159-oort1-x86_64r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge/logs/x86_64-natty-cbuild159-oort1-x86_64r1

-PASS: gcc.target/i386/pr32661-1.c scan-assembler-times mov 2
+FAIL: gcc.target/i386/pr32661-1.c scan-assembler-times mov 2
-PASS: gcc.target/i386/pr34256.c scan-assembler-times mov 2
+FAIL: gcc.target/i386/pr34256.c scan-assembler-times mov 2

Note that the changes are probably due to 'mov' being in the test name.

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_move_creation_anti-dep_edge/logs/x86_64-natty-cbuild159-oort1-x86_64r1/gcc-testsuite.txt

cbuild-checked: x86_64-natty-cbuild159-oort1-x86_64r1

Revision history for this message
Ulrich Weigand (uweigand) wrote :

This is OK.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ChangeLog.linaro'
2--- ChangeLog.linaro 2011-07-21 12:40:44 +0000
3+++ ChangeLog.linaro 2011-07-31 13:22:14 +0000
4@@ -1,3 +1,13 @@
5+2011-07-31 Revital Eres <revital.eres@linaro.org>
6+
7+ gcc/
8+ Backport from trunk -r176972:
9+
10+ * ddg.c (create_ddg_dep_from_intra_loop_link): Remove the creation
11+ of anti-dep edge from a branch.
12+ (add_cross_iteration_register_deps): Create anti-dep edge from
13+ a branch.
14+
15 2011-07-21 Richard Sandiford <rdsandiford@googlemail.com>
16
17 gcc/
18
19=== modified file 'gcc/ddg.c'
20--- gcc/ddg.c 2011-07-05 09:02:18 +0000
21+++ gcc/ddg.c 2011-07-31 13:22:14 +0000
22@@ -197,11 +197,6 @@
23 }
24 }
25
26- /* If a true dep edge enters the branch create an anti edge in the
27- opposite direction to prevent the creation of reg-moves. */
28- if ((DEP_TYPE (link) == REG_DEP_TRUE) && JUMP_P (dest_node->insn))
29- create_ddg_dep_no_link (g, dest_node, src_node, ANTI_DEP, REG_DEP, 1);
30-
31 latency = dep_cost (link);
32 e = create_ddg_edge (src_node, dest_node, t, dt, latency, distance);
33 add_edge_to_ddg (g, e);
34@@ -305,8 +300,11 @@
35
36 gcc_assert (first_def_node);
37
38+ /* Always create the edge if the use node is a branch in
39+ order to prevent the creation of reg-moves. */
40 if (DF_REF_ID (last_def) != DF_REF_ID (first_def)
41- || !flag_modulo_sched_allow_regmoves)
42+ || !flag_modulo_sched_allow_regmoves
43+ || JUMP_P (use_node->insn))
44 create_ddg_dep_no_link (g, use_node, first_def_node, ANTI_DEP,
45 REG_DEP, 1);
46

Subscribers

People subscribed via source and target branches