Merge lp:~eres/gcc-linaro/sms_misc_fixes_linaro into lp:gcc-linaro/4.5

Proposed by Revital Eres
Status: Merged
Approved by: Ulrich Weigand
Approved revision: no longer in the source branch.
Merged at revision: 99533
Proposed branch: lp:~eres/gcc-linaro/sms_misc_fixes_linaro
Merge into: lp:gcc-linaro/4.5
Diff against target: 70 lines (+27/-11)
2 files modified
ChangeLog.linaro (+10/-0)
gcc/modulo-sched.c (+17/-11)
To merge this branch: bzr merge lp:~eres/gcc-linaro/sms_misc_fixes_linaro
Reviewer Review Type Date Requested Status
Ulrich Weigand (community) Approve
Review via email: mp+69920@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild has taken a snapshot of this branch at r99531 and queued it for build.

The snapshot is available at:
 http://ex.seabright.co.nz/snapshots/gcc-linaro-4.5+bzr99531~eres~sms_misc_fixes_linaro.tar.xdelta3.xz

and will be built on the following builders:

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.5+bzr99531~eres~sms_misc_fixes_linaro
cbuild-ancestor: lp:gcc-linaro+bzr99530
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote :

Poking the build system...
cbuild-state: queue

Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild has taken a snapshot of this branch at r99531 and queued it for build.

The snapshot is available at:
 http://ex.seabright.co.nz/snapshots/gcc-linaro-4.5+bzr99531~eres~sms_misc_fixes_linaro.tar.xdelta3.xz

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.5+bzr99531~eres~sms_misc_fixes_linaro
cbuild-ancestor: lp:gcc-linaro+bzr99530
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on x86_64-natty-cbuild159-oort3-x86_64r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_misc_fixes_linaro/logs/x86_64-natty-cbuild159-oort3-x86_64r1

The testsuite results are the same as the branch point lp:gcc-linaro+bzr99530

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_misc_fixes_linaro/logs/x86_64-natty-cbuild159-oort3-x86_64r1/gcc-testsuite.txt

cbuild-checked: x86_64-natty-cbuild159-oort3-x86_64r1

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on i686-natty-cbuild159-oort2-i686r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_misc_fixes_linaro/logs/i686-natty-cbuild159-oort2-i686r1

The testsuite results are the same as the branch point lp:gcc-linaro+bzr99530

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_misc_fixes_linaro/logs/i686-natty-cbuild159-oort2-i686r1/gcc-testsuite.txt

cbuild-checked: i686-natty-cbuild159-oort2-i686r1

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild159-ursa3-cortexa9r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_misc_fixes_linaro/logs/armv7l-natty-cbuild159-ursa3-cortexa9r1

The testsuite results are the same as the branch point lp:gcc-linaro+bzr99530

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.5+bzr99531~eres~sms_misc_fixes_linaro/logs/armv7l-natty-cbuild159-ursa3-cortexa9r1/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild159-ursa3-cortexa9r1

Revision history for this message
Ulrich Weigand (uweigand) wrote :

This is OK.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ChangeLog.linaro'
2--- ChangeLog.linaro 2011-07-21 12:40:44 +0000
3+++ ChangeLog.linaro 2011-07-31 12:14:52 +0000
4@@ -1,3 +1,13 @@
5+2011-07-31 Revital Eres <revital.eres@linaro.org>
6+
7+ gcc/
8+ Backport from trunk -r176970:
9+
10+ * modulo-sched.c: Change comment.
11+ (reset_sched_times): Fix print message.
12+ (print_partial_schedule): Add print
13+ info.
14+
15 2011-07-21 Richard Sandiford <rdsandiford@googlemail.com>
16
17 gcc/
18
19=== modified file 'gcc/modulo-sched.c'
20--- gcc/modulo-sched.c 2011-07-04 11:39:09 +0000
21+++ gcc/modulo-sched.c 2011-07-31 12:14:52 +0000
22@@ -84,13 +84,14 @@
23 II cycles (i.e. use register copies to prevent a def from overwriting
24 itself before reaching the use).
25
26- SMS works with countable loops whose loop count can be easily
27- adjusted. This is because we peel a constant number of iterations
28- into a prologue and epilogue for which we want to avoid emitting
29- the control part, and a kernel which is to iterate that constant
30- number of iterations less than the original loop. So the control
31- part should be a set of insns clearly identified and having its
32- own iv, not otherwise used in the loop (at-least for now), which
33+ SMS works with countable loops (1) whose control part can be easily
34+ decoupled from the rest of the loop and (2) whose loop count can
35+ be easily adjusted. This is because we peel a constant number of
36+ iterations into a prologue and epilogue for which we want to avoid
37+ emitting the control part, and a kernel which is to iterate that
38+ constant number of iterations less than the original loop. So the
39+ control part should be a set of insns clearly identified and having
40+ its own iv, not otherwise used in the loop (at-least for now), which
41 initializes a register before the loop to the number of iterations.
42 Currently SMS relies on the do-loop pattern to recognize such loops,
43 where (1) the control part comprises of all insns defining and/or
44@@ -598,8 +599,8 @@
45 /* Print the scheduling times after the rotation. */
46 fprintf (dump_file, "crr_insn->node=%d (insn id %d), "
47 "crr_insn->cycle=%d, min_cycle=%d", crr_insn->node->cuid,
48- INSN_UID (crr_insn->node->insn), SCHED_TIME (u),
49- normalized_time);
50+ INSN_UID (crr_insn->node->insn), normalized_time,
51+ new_min_cycle);
52 if (JUMP_P (crr_insn->node->insn))
53 fprintf (dump_file, " (branch)");
54 fprintf (dump_file, "\n");
55@@ -2550,8 +2551,13 @@
56 fprintf (dump, "\n[ROW %d ]: ", i);
57 while (ps_i)
58 {
59- fprintf (dump, "%d, ",
60- INSN_UID (ps_i->node->insn));
61+ if (JUMP_P (ps_i->node->insn))
62+ fprintf (dump, "%d (branch), ",
63+ INSN_UID (ps_i->node->insn));
64+ else
65+ fprintf (dump, "%d, ",
66+ INSN_UID (ps_i->node->insn));
67+
68 ps_i = ps_i->next_in_row;
69 }
70 }

Subscribers

People subscribed via source and target branches