Merge lp:~eres/gcc-linaro/sms_misc_fixes-4.6 into lp:gcc-linaro/4.6

Proposed by Revital Eres
Status: Merged
Approved by: Ulrich Weigand
Approved revision: no longer in the source branch.
Merged at revision: 106783
Proposed branch: lp:~eres/gcc-linaro/sms_misc_fixes-4.6
Merge into: lp:gcc-linaro/4.6
Diff against target: 69 lines (+26/-11)
2 files modified
ChangeLog.linaro (+9/-0)
gcc/modulo-sched.c (+17/-11)
To merge this branch: bzr merge lp:~eres/gcc-linaro/sms_misc_fixes-4.6
Reviewer Review Type Date Requested Status
Ulrich Weigand (community) Approve
Review via email: mp+69915@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Linaro Toolchain Builder (cbuild) wrote :

cbuild has taken a snapshot of this branch at r106783 and queued it for build.

The snapshot is available at:
 http://ex.seabright.co.nz/snapshots/gcc-linaro-4.6+bzr106783~eres~sms_misc_fixes-4.6.tar.xdelta3.xz

and will be built on the following builders:
 a9-builder armv5-builder i686 x86_64

You can track the build queue at:
 http://ex.seabright.co.nz/helpers/scheduler

cbuild-snapshot: gcc-linaro-4.6+bzr106783~eres~sms_misc_fixes-4.6
cbuild-ancestor: lp:gcc-linaro/4.6+bzr106782
cbuild-state: check

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on i686-natty-cbuild159-oort2-i686r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106783~eres~sms_misc_fixes-4.6/logs/i686-natty-cbuild159-oort2-i686r1

The testsuite results are the same as the branch point lp:gcc-linaro/4.6+bzr106782

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106783~eres~sms_misc_fixes-4.6/logs/i686-natty-cbuild159-oort2-i686r1/gcc-testsuite.txt

cbuild-checked: i686-natty-cbuild159-oort2-i686r1

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on x86_64-natty-cbuild159-oort3-x86_64r1.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106783~eres~sms_misc_fixes-4.6/logs/x86_64-natty-cbuild159-oort3-x86_64r1

The testsuite results are the same as the branch point lp:gcc-linaro/4.6+bzr106782

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106783~eres~sms_misc_fixes-4.6/logs/x86_64-natty-cbuild159-oort3-x86_64r1/gcc-testsuite.txt

cbuild-checked: x86_64-natty-cbuild159-oort3-x86_64r1

Revision history for this message
Michael Hope (michaelh1) wrote :

cbuild successfully built this on armv7l-natty-cbuild159-ursa1-armv5r2.

The build results are available at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106783~eres~sms_misc_fixes-4.6/logs/armv7l-natty-cbuild159-ursa1-armv5r2

The testsuite results are the same as the branch point lp:gcc-linaro/4.6+bzr106782

The full testsuite results are at:
 http://ex.seabright.co.nz/build/gcc-linaro-4.6+bzr106783~eres~sms_misc_fixes-4.6/logs/armv7l-natty-cbuild159-ursa1-armv5r2/gcc-testsuite.txt

cbuild-checked: armv7l-natty-cbuild159-ursa1-armv5r2

Revision history for this message
Ulrich Weigand (uweigand) wrote :

This is OK.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ChangeLog.linaro'
2--- ChangeLog.linaro 2011-07-21 11:30:53 +0000
3+++ ChangeLog.linaro 2011-07-31 11:09:17 +0000
4@@ -1,3 +1,12 @@
5+2011-07-31 Revital Eres <revital.eres@linaro.org>
6+
7+ gcc/
8+ Backport from trunk -r176970:
9+
10+ * modulo-sched.c: Change comment.
11+ (reset_sched_times): Fix print message.
12+ (print_partial_schedule): Add print info.
13+
14 2011-07-21 Richard Sandiford <rdsandiford@googlemail.com>
15
16 gcc/
17
18=== modified file 'gcc/modulo-sched.c'
19--- gcc/modulo-sched.c 2011-07-04 12:01:34 +0000
20+++ gcc/modulo-sched.c 2011-07-31 11:09:17 +0000
21@@ -84,13 +84,14 @@
22 II cycles (i.e. use register copies to prevent a def from overwriting
23 itself before reaching the use).
24
25- SMS works with countable loops whose loop count can be easily
26- adjusted. This is because we peel a constant number of iterations
27- into a prologue and epilogue for which we want to avoid emitting
28- the control part, and a kernel which is to iterate that constant
29- number of iterations less than the original loop. So the control
30- part should be a set of insns clearly identified and having its
31- own iv, not otherwise used in the loop (at-least for now), which
32+ SMS works with countable loops (1) whose control part can be easily
33+ decoupled from the rest of the loop and (2) whose loop count can
34+ be easily adjusted. This is because we peel a constant number of
35+ iterations into a prologue and epilogue for which we want to avoid
36+ emitting the control part, and a kernel which is to iterate that
37+ constant number of iterations less than the original loop. So the
38+ control part should be a set of insns clearly identified and having
39+ its own iv, not otherwise used in the loop (at-least for now), which
40 initializes a register before the loop to the number of iterations.
41 Currently SMS relies on the do-loop pattern to recognize such loops,
42 where (1) the control part comprises of all insns defining and/or
43@@ -598,8 +599,8 @@
44 /* Print the scheduling times after the rotation. */
45 fprintf (dump_file, "crr_insn->node=%d (insn id %d), "
46 "crr_insn->cycle=%d, min_cycle=%d", crr_insn->node->cuid,
47- INSN_UID (crr_insn->node->insn), SCHED_TIME (u),
48- normalized_time);
49+ INSN_UID (crr_insn->node->insn), normalized_time,
50+ new_min_cycle);
51 if (JUMP_P (crr_insn->node->insn))
52 fprintf (dump_file, " (branch)");
53 fprintf (dump_file, "\n");
54@@ -2550,8 +2551,13 @@
55 fprintf (dump, "\n[ROW %d ]: ", i);
56 while (ps_i)
57 {
58- fprintf (dump, "%d, ",
59- INSN_UID (ps_i->node->insn));
60+ if (JUMP_P (ps_i->node->insn))
61+ fprintf (dump, "%d (branch), ",
62+ INSN_UID (ps_i->node->insn));
63+ else
64+ fprintf (dump, "%d, ",
65+ INSN_UID (ps_i->node->insn));
66+
67 ps_i = ps_i->next_in_row;
68 }
69 }

Subscribers

People subscribed via source and target branches