Code review comment for lp:~epics-core/epics-base/link-support-2

Revision history for this message
mdavidsaver (mdavidsaver) wrote :

I haven't check your latest changes, so this may be fixed. I find that the jlif free callback isn't being called if parsing is stopped. Thus a memory leak.

I would definitely say a unit test is in order w/ ref. counting to detect situations like this. Something with lnkConst.c which does link modification and checks a ref. count on shutdown to ensure that cleanup is done.

« Back to merge proposal