Merge ~epics-core/epics-base/+git/fixups:aSubInit into ~epics-core/epics-base/+git/epics-base:3.14

[mdavidsaver]

For aSubRecord, handle EFLG="On Change" when an initial function (INAM) is used. Copy VAL* -> OVL* and NOV* -> ONV*.

Missed during my previous round of old-value initialization handling b63e381fbefd0336cb3109f9af4c5cfa757ae1d2

An almost trivial change. If we weren't preparing for a release I'd just push this, but it has no test coverage, and I'm not likely to produce any in the next few days.

[Andrew Johnson (anj)]

Thanks for waiting for a review as you'd have been wrong to push this change as it is.

The NOVx fields do not hold a byte-count, so feeding their values directly to memcpy() would only be correct when FTVx=CHAR or UCHAR, not for other data types. The correct number of bytes to copy should be calculated with
   (&prec->nova)[i] * dbValueSize((&prec->ftva)[i])

Personally I would also save the element count in a variable to avoid it being looked up twice inside the loop, but compilers may be clever enough to do that kind of thing for themselves now.

review: Needs Fixing

[Andrew Johnson (anj)]

Oh, and it shouldn't be using the NOVx fields for the element count at all, those hold the max number of elements that can be stored, not the current number of values present which is kept in the NEVx fields. Look at the monitor() routine for the correct usage.

Now I *really* must go back to bed.

[Andrew Johnson (anj)]

Fixing this now, and will merge the other as well.

[Andrew Johnson (anj)]

Fixed, merging.

review: Approve

diff --git a/src/rec/aSubRecord.c b/src/rec/aSubRecord.c
index e3983ed..087b35d 100644
--- a/src/rec/aSubRecord.c
+++ b/src/rec/aSubRecord.c
@@ -207,6 +207,14 @@ static long init_record(aSubRecord *prec, int pass)
     }
     strcpy(prec->onam, prec->snam);
     prec->oval = prec->val;
+    for (i = 0; i < NUM_ARGS; i++) {
+        epicsUInt32 nev = (&prec->neva)[i];
+
+        (&prec->onva)[i] = nev;
+        if (nev)
+            memcpy((&prec->ovla)[i], (&prec->vala)[i],
+                dbValueSize((&prec->ftva)[i]) * nev);
+    }
     return 0;
 }