Merge lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937 into lp:~openerp-community/server-env-tools/6.1-mass_editing

Proposed by Mariano Ruiz on 2013-06-05
Status: Merged
Merged at revision: 42
Proposed branch: lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937
Merge into: lp:~openerp-community/server-env-tools/6.1-mass_editing
Diff against target: 12 lines (+1/-1)
1 file modified
mass_editing/mass_editing.py (+1/-1)
To merge this branch: bzr merge lp:~eoc/server-env-tools/6.1-mass_editing-fix_bug_1187937
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Needs Information on 2013-07-01
Guewen Baconnier @ Camptocamp Needs Information on 2013-06-18
Stefan Rijnhart (Opener) 2013-06-05 Approve on 2013-06-05
Review via email: mp+167643@code.launchpad.net

Description of the change

This branch fix the error #1187937.

To post a comment you must log in.

Thanks for the fix! You might want to use model_ids.append(found_model_ids[0]) though.

review: Needs Fixing
42. By Mariano Ruiz on 2013-06-05

[FIX] Better operation syntax

Mariano Ruiz (marianoruiz) wrote :

Done! Rev 42.

You're quick! Thanks for the change.

review: Approve
review: Approve (code review)

LGTM

review: Approve (code review, no test)
review: Needs Information
Holger Brunn (Therp) (hbrunn) wrote :

I ask myself the same thing

review: Needs Information
debaetsr (rubendebaets) wrote :

Hi friend!

Look at that! Wooow! It's so amazing and interesting, and even sometimes shocking! Just take a look here <http://suit.kitefamily.us/e4ccrzv>

Thanks for your consideration, ruben

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'mass_editing/mass_editing.py'
2--- mass_editing/mass_editing.py 2013-05-07 18:28:03 +0000
3+++ mass_editing/mass_editing.py 2013-06-05 21:51:27 +0000
4@@ -50,7 +50,7 @@
5 for key, val in active_model_obj._inherits.items():
6 found_model_ids = model_obj.search(cr, uid, [('model', '=', key)])
7 if found_model_ids:
8- model_ids += found_model_ids[0]
9+ model_ids.append(found_model_ids[0])
10 return {'value': {'model_ids': [(6, 0, model_ids)]}}
11
12 def create_action(self, cr, uid, ids, context=None):

Subscribers

People subscribed via source and target branches