Merge lp:~ensoft-opensource/ensoft-sextant/startup-service into lp:ensoft-sextant

[Phil Connell]

Add a 'sextantweb' service config file, to run the sextant web server.

Add etc/sextantweb.conf, a file to be copied to /etc/init to provide a service called sextantweb which can be started/stopped using sudo service sextantweb start.

I am very hazy on whether or not this file is correct - I've tested it a bit on a virtual machine and it didn't break anything, but I can't guarantee that it really is right (I'm a bit scared of things which run at startup). Please don't merge this until someone who knows about these things has had a look at it!

Update: fixes from testing on sandbox.

[Patrick Stevens (patrickas)]

Two comments

[Patrick Stevens (patrickas)]

It seems to work correctly without that first commented line - shall I remove it?

[Simon C (slimey)]

http://en.wikipedia.org/wiki/Runlevel - your current [2-5] looks right (as much as we care, this is all a bit retro tbh)

(And yes, I would kill the tty1 comment)

[ChrisD (gingerchris)]

Yeah, go for it.

On 1 September 2014 11:38, Patrick Stevens <email address hidden> wrote:

> It seems to work correctly without that first commented line - shall I
> remove it?
> --
>
> https://code.launchpad.net/~ensoft-opensource/ensoft-sextant/startup-service/+merge/232532
> Your team Ensoft Open Source is requested to review the proposed merge of
> lp:~ensoft-opensource/ensoft-sextant/startup-service into lp:ensoft-sextant.
>

[Phil Connell (pconnell)]

I'd suggest mirroring what endroid does, for a bit of consistency (since we know it works!):

- Move to etc/init/sextantweb.conf in the repo.
- Add description and author fields.
- Consider using more descriptive triggers for start on/stop on.
- Starting/stopping on networking being available seems like a decent idea, since it's a bit useless otherwise.

http://bazaar.launchpad.net/~ensoft-lander/endroid/trunk/view/head:/etc/init/endroid.conf

review: Needs Fixing

[Patrick Stevens (patrickas)]

> I'd suggest mirroring what endroid does, for a bit of consistency (since we
> know it works!):
>
> - Move to etc/init/sextantweb.conf in the repo.
> - Add description and author fields.
> - Consider using more descriptive triggers for start on/stop on.
> - Starting/stopping on networking being available seems like a decent idea,
> since it's a bit useless otherwise.
>
> http://bazaar.launchpad.net/~ensoft-
> lander/endroid/trunk/view/head:/etc/init/endroid.conf
Sounds sensible - I've done that. Didn't think of looking in Endroid!

[Phil Connell (pconnell)]

Approved, pending Patrick approving my changes.

review: Approve

[Patrick Stevens (patrickas)]

review: Approve

=== added directory 'etc/init'
=== added file 'etc/init/sextantweb.conf'
--- etc/init/sextantweb.conf	1970-01-01 00:00:00 +0000
+++ etc/init/sextantweb.conf	2014-09-02 13:34:00 +0000
@@ -0,0 +1,15 @@
+# This service runs sextant web on startup until shutdown,
+# using whatever configuration file sextant is currently using.
+
+description "Sextant Web server"
+author "Ensoft Limited"
+
+start on net-device-up
+stop on stopping network
+stop on starting shutdown
+
+respawn
+script
+  export SEXTANT_CONFIG=/etc/sextant.conf
+  exec sextant web
+end script

=== modified file 'setup.py'
--- setup.py	2014-09-01 10:18:31 +0000
+++ setup.py	2014-09-02 13:34:00 +0000
@@ -23,7 +23,14 @@
     # somehow before using Sextant; we recommend pip.
     install_requires=['twisted'],
     #install_requires=['neo4jrestclient', 'twisted'],
-    package_data={'resources': ['sextant/web/*'], 'etc': ['*.conf']},
+    package_data={
+        'resources': ['sextant/web/*'],
+        'etc': ['*.conf', 'init/*'],
+    },
+    data_files=[
+        ('/etc', ['etc/sextant.conf']),
+        ('/etc/init', ['etc/init/sextantweb.conf']),
+    ]
 )