Merge lp:~enr0n/ubuntu/jammy/apport/lp.1952947 into lp:~ubuntu-core-dev/ubuntu/jammy/apport/ubuntu

Proposed by Nick Rosbrook
Status: Merged
Merged at revision: 2890
Proposed branch: lp:~enr0n/ubuntu/jammy/apport/lp.1952947
Merge into: lp:~ubuntu-core-dev/ubuntu/jammy/apport/ubuntu
Diff against target: 53 lines (+24/-0)
3 files modified
apport/ui.py (+13/-0)
debian/changelog (+6/-0)
man/apport-cli.1 (+5/-0)
To merge this branch: bzr merge lp:~enr0n/ubuntu/jammy/apport/lp.1952947
Reviewer Review Type Date Requested Status
Brian Murray Pending
Review via email: mp+415635@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Nick Rosbrook (enr0n) wrote :

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'apport/ui.py'
2--- apport/ui.py 2021-12-01 22:11:09 +0000
3+++ apport/ui.py 2022-02-15 22:16:37 +0000
4@@ -727,6 +727,19 @@
5 self.ui_error_message(_('Invalid problem report'), excstr(e))
6 return True
7 elif self.options.window:
8+ if os.getenv('XDG_SESSION_TYPE') == 'wayland':
9+ self.ui_error_message(_('Cannot create report'),
10+ _('The window option cannot be used on '
11+ 'Wayland.\n\nPlease find the window\'s '
12+ 'process ID and then run \'ubuntu-bug '
13+ '<process ID>\'.'
14+ '\n\nThe process ID can be found '
15+ 'by running the System Monitor application. '
16+ 'In the Processes tab, scroll until you '
17+ 'find the correct application. The process '
18+ 'ID is the number listed in the ID column.'))
19+ return True
20+
21 self.ui_info_message('', _('After closing this message '
22 'please click on an application window to report a problem about it.'))
23 xprop = subprocess.Popen(['xprop', '_NET_WM_PID'],
24
25=== modified file 'debian/changelog'
26--- debian/changelog 2022-01-25 17:59:14 +0000
27+++ debian/changelog 2022-02-15 22:16:37 +0000
28@@ -1,3 +1,9 @@
29+apport (2.20.11-0ubuntu77) UNRELEASED; urgency=medium
30+
31+ * apport/ui.py: Error out when -w option is used on wayland (LP: #1952947).
32+
33+ -- Nick Rosbrook <nick.rosbrook@canonical.com> Tue, 15 Feb 2022 10:10:59 -0500
34+
35 apport (2.20.11-0ubuntu76) jammy; urgency=medium
36
37 * data/package-hooks/ubuntu-desktop-installer.py: Add in a new package hook
38
39=== modified file 'man/apport-cli.1'
40--- man/apport-cli.1 2011-04-19 08:21:30 +0000
41+++ man/apport-cli.1 2022-02-15 22:16:37 +0000
42@@ -125,6 +125,11 @@
43 the name of the package, or if the application window has stopped responding
44 and you cannot report the problem from the "Help" menu of the application.
45
46+This option is not supported on Wayland. Users running Wayland should use another
47+option such as
48+.B -P
49+to specify the application.
50+
51 .SH ENVIRONMENT
52
53 .TP

Subscribers

People subscribed via source and target branches