Merge ~enr0n/ubuntu/+source/triton:fix-lp2025279 into ubuntu/+source/triton:ubuntu/devel

[Nick Rosbrook]

PPA: https://launchpad.net/~enr0n/+archive/ubuntu/proposed-migration/+packages?field.name_filter=triton&field.status_filter=published&field.series_filter=

[Julian Andres Klode (juliank)]

I mean this looks good to me, but I'd prefer someone not in foundations to sponsor this so we get more sponsor coverage for Nick's coredev application.

[Steve Langasek (vorlon)]

review: Needs Information

[Steve Langasek (vorlon)]

(please resubscribe ubuntu-sponsors after addressing)

[Steve Langasek (vorlon)]

On Mon, Jul 03, 2023 at 05:56:00PM -0000, Nick Rosbrook wrote:

> Ah, sorry. After resolving the first issue, the build still failed with
> an LTO related issue. So disabling LTO is also needed to resolve the
> FTBFS.

Please show more detail (somewhere) about what the build failure was so that
we can see it was LTO-related.

[Nick Rosbrook (enr0n)]

> On Mon, Jul 03, 2023 at 05:56:00PM -0000, Nick Rosbrook wrote:
>
> > Ah, sorry. After resolving the first issue, the build still failed with
> > an LTO related issue. So disabling LTO is also needed to resolve the
> > FTBFS.
>
> Please show more detail (somewhere) about what the build failure was so that
> we can see it was LTO-related.

Mentioned on the bug report: https://bugs.launchpad.net/ubuntu/+source/triton/+bug/2025279/comments/2.

[Athos Ribeiro (athos-ribeiro)]

LGTM

Uploaded.

Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading triton_2.0.0.post1-3ubuntu1.dsc: done.
  Uploading triton_2.0.0.post1-3ubuntu1.debian.tar.xz: done.
  Uploading triton_2.0.0.post1-3ubuntu1_source.buildinfo: done.
  Uploading triton_2.0.0.post1-3ubuntu1_source.changes: done.
Successfully uploaded packages.

review: Approve

Unmerged commits

1c63085... by Nick Rosbrook on 2023-06-28

update changelog

5623382... by Nick Rosbrook on 2023-06-28

update maintainer

0dbfdfa... by Nick Rosbrook on 2023-06-28

debian/rules: disable LTO

a8f7c1b... by Nick Rosbrook on 2023-06-28

debian/control: use explicit Build-Depends: llvm-14-dev

Since Build-Depends: libmlir-14-dev mlir-14-tools imply llvm-14-dev is
required for the build, be explicit in that dep rather than using
llvm-dev.

diff --git a/debian/changelog b/debian/changelog
index c3b0906..b087262 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,12 @@
+triton (2.0.0.post1-3ubuntu1) mantic; urgency=medium
+
+  * Fix FTBFS (LP: #2025279):
+    - debian/control: use explicit Build-Depends: llvm-14-dev instead of
+      llvm-dev
+    - debian/rules: disable LTO
+
+ -- Nick Rosbrook <[e-mail]>  Wed, 28 Jun 2023 13:26:16 -0400
+
 triton (2.0.0.post1-3) unstable; urgency=medium
 
   * Uploading to unstable.
diff --git a/debian/control b/debian/control
index 6274a1e..3269b67 100644
--- a/debian/control
+++ b/debian/control
@@ -1,13 +1,14 @@
 Source: triton
 Section: python
 Priority: optional
-Maintainer: Debian Deep Learning Team <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian Deep Learning Team <[e-mail]>
 Uploaders: M. Zhou <[e-mail]>, Petter Reinholdtsen <[e-mail]>
 Build-Depends: cmake,
                debhelper-compat (= 13),
                dh-python,
                libmlir-14-dev,
-               llvm-dev,
+               llvm-14-dev,
                mlir-14-tools,
                python3-all-dev,
                python3-sphinx,
diff --git a/debian/rules b/debian/rules
index 4b77a79..3864999 100755
--- a/debian/rules
+++ b/debian/rules
@@ -1,5 +1,6 @@
 #! /usr/bin/make -f
 
+export DEB_BUILD_MAINT_OPTIONS=optimize=-lto
 export PYBUILD_NAME=triton
 %:
 	dh $@ --with python3,sphinxdoc --buildsystem=pybuild