Merge ~enr0n/ubuntu/+source/systemd:ubuntu-focal-sru into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-focal

[Nick Rosbrook]

SRU to fix a couple bugs in Focal. We may be adding a third bug if we can get a reproducer soon. I have requested autopkgtest runs for the package build in my PPA (https://launchpad.net/~enr0n/+archive/ubuntu/systemd-245/+packages), and I will post the results when I have them.

[Nick Rosbrook (enr0n)]

It looks like the test beds for focal do not support link alternative names, so I will just drop the tests that rely on that.

[Nick Rosbrook (enr0n)]

autopkgtest on most arches is looking good. The failure on amd64 is one of the usual flaky tests in upstream tests (TEST-36-NUMAPOLICY).

systemd 245.4-4ubuntu3.20~ppa3 (s390x) -- Pass: https://autopkgtest.ubuntu.com/results/autopkgtest-focal-enr0n-systemd-245/focal/s390x/s/systemd/20230223_215845_a5bdd@/log.gz
systemd 245.4-4ubuntu3.20~ppa3 (arm64) -- Pass: https://autopkgtest.ubuntu.com/results/autopkgtest-focal-enr0n-systemd-245/focal/arm64/s/systemd/20230223_231724_d28f5@/log.gz
systemd 245.4-4ubuntu3.20~ppa3 (ppc64el) -- Pass: https://autopkgtest.ubuntu.com/results/autopkgtest-focal-enr0n-systemd-245/focal/ppc64el/s/systemd/20230223_225526_a5bdd@/log.gz
systemd 245.4-4ubuntu3.20~ppa3 (amd64) -- Fail: https://autopkgtest.ubuntu.com/results/autopkgtest-focal-enr0n-systemd-245/focal/amd64/s/systemd/20230224_021741_a5bdd@/log.gz

On armhf, we are hitting LP: #1991285, and the flaky test-execute. I think we need to work around LP: #1991285 though. It would not actually be considered a regression to britney, but I don't think we want to leave that hanging around.

[Nick Rosbrook (enr0n)]

Here's an armhf run with the workaround in place:

systemd 245.4-4ubuntu3.20~ppa5 (armhf) -- Pass: https://autopkgtest.ubuntu.com/results/autopkgtest-focal-enr0n-systemd-245/focal/armhf/s/systemd/20230227_191413_799b3@/log.gz

[Lukas Märdian (slyon)]

We didn't get a reproducer for https://bugs.launchpad.net/shiner/+bug/2007667 so we'll leave that out for now.

Thanks for the test build and autopkgtest pre-testing + analysis, this is very helpful!
We have 3 LP bugs listed in d/changelog here, autopkgtest fixes do not necessarily need to be tracked through the SRU process, but I see all three have the SRU template already prepared, so this is even better and more transparent! Kudos.

Wrt bug #2002445: we need to make sure to also land it for Jammy (and Kinetic), so we won't regress people when upgrading from Focal to Jammy. I guess this will be a SRU team requirement before this can be landed in focal-updates.

There's also a little nitpick inline, but I don't think we need another iteration for that.

review: Approve

[Lukas Märdian (slyon)]

Ah! Another quick note for future work:

We could be using the "Gbp-Pq: Topic lpXXXXX" pseudo header, to sort corresponding patches into a single debian/patches/lpXXXXX directory.

[Nick Rosbrook (enr0n)]

Thanks for reviewing! And thanks for the Gbp-Pq: Topic tip, I will use that next time.

diff --git a/debian/changelog b/debian/changelog
index e6aa745..0edd425 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,23 @@
+systemd (245.4-4ubuntu3.20) focal; urgency=medium
+
+  * udev: avoid NIC renaming race with kernel (LP: #2002445)
+    Files:
+    - debian/patches/lp2002445-netlink-do-not-fail-when-new-interface-name-is-already-us.patch
+    - debian/patches/lp2002445-netlink-introduce-rtnl_get-delete_link_alternative_names.patch
+    - debian/patches/lp2002445-sd-netlink-restore-altname-on-error-in-rtnl_set_link_name.patch
+    - debian/patches/lp2002445-udev-attempt-device-rename-even-if-interface-is-up.patch
+    - debian/patches/lp2002445-udev-net-allow-new-link-name-as-an-altname-before-renamin.patch
+    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=e34409f9d68a15220aa36cbae219d4f4987e5207
+  * test-seccomp: accept ENOSYS from sysctl(2) too (LP: #1933090)
+    Thanks to Roxana Nicolescu
+    File: debian/patches/lp1933090-test-seccomp-accept-ENOSYS-from-sysctl-2-too.patch
+    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=706f2e0c787cade9609d0f2b37634d7eb4517beb
+  * debian/test: ignore systemd-remount-fs.service failure on armhf (LP: #1991285)
+    File: debian/tests/boot-and-services
+    https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=cddc66ef6ecfb555dfd38c5f5fe8572efb424114
+
+ -- Nick Rosbrook <[e-mail]>  Mon, 27 Feb 2023 10:11:13 -0500
+
 systemd (245.4-4ubuntu3.19) focal; urgency=medium
 
   [ dann frazier ]
diff --git a/debian/patches/lp1933090-test-seccomp-accept-ENOSYS-from-sysctl-2-too.patch b/debian/patches/lp1933090-test-seccomp-accept-ENOSYS-from-sysctl-2-too.patch
new file mode 100644
index 0000000..21a975d
--- /dev/null
+++ b/debian/patches/lp1933090-test-seccomp-accept-ENOSYS-from-sysctl-2-too.patch
@@ -0,0 +1,25 @@
+From: =?utf-8?q?Zbigniew_J=C4=99drzejewski-Szmek?= <[e-mail]>
+Date: Tue, 22 Sep 2020 19:05:17 +0200
+Subject: test-seccomp: accept ENOSYS from sysctl(2) too
+
+Origin: upstream, https://github.com/systemd/systemd/commit/0af05e485a3a88f454c714901eb6109307dc893e
+Bug-Ubuntu: https://launchpad.net/bugs/1933090
+
+It seems that kernel 5.9 started returning that.
+---
+ src/test/test-seccomp.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/test/test-seccomp.c b/src/test/test-seccomp.c
+index 22953a2..9c37655 100644
+--- a/src/test/test-seccomp.c
++++ b/src/test/test-seccomp.c
+@@ -308,7 +308,7 @@ static void test_protect_sysctl(void) {
+         if (pid == 0) {
+ #if defined __NR__sysctl && __NR__sysctl >= 0
+                 assert_se(syscall(__NR__sysctl, NULL) < 0);
+-                assert_se(errno == EFAULT);
++                assert_se(IN_SET(errno, EFAULT, ENOSYS));
+ #endif
+ 
+                 assert_se(seccomp_protect_sysctl() >= 0);
diff --git a/debian/patches/lp2002445-netlink-do-not-fail-when-new-interface-name-is-already-us.patch b/debian/patches/lp2002445-netlink-do-not-fail-when-new-interface-name-is-already-us.patch
new file mode 100644
index 0000000..505976d
--- /dev/null
+++ b/debian/patches/lp2002445-netlink-do-not-fail-when-new-interface-name-is-already-us.patch
@@ -0,0 +1,50 @@
+From: Yu Watanabe <[e-mail]>
+Date: Fri, 17 Jul 2020 21:31:24 +0900
+Subject: netlink: do not fail when new interface name is already used as an
+  alternative name
+
+Origin: upstream, https://github.com/systemd/systemd/commit/434a34838034347f45fb9a47df55b1a36e5addfd
+Bug-Ubuntu: https://launchpad.net/bugs/2002445
+
+When renaming a network interface, the new name may be used as an
+alternative name. In that case, let's swap the current name and the
+alternative name. That is, first drop the new name from the list of
+alternative names, then rename the interface, finally set the old name
+as an alternative name.
+
+(partial backport with 080afbb57c4b2d592c5cf77ab10c6e0be74f0732 amended)
+---
+ src/libsystemd/sd-netlink/netlink-util.c | 13 +++++++++++++
+ 1 file changed, 13 insertions(+)
+
+diff --git a/src/libsystemd/sd-netlink/netlink-util.c b/src/libsystemd/sd-netlink/netlink-util.c
+index 83f2a9b..7e3ec53 100644
+--- a/src/libsystemd/sd-netlink/netlink-util.c
++++ b/src/libsystemd/sd-netlink/netlink-util.c
+@@ -9,6 +9,7 @@
+ 
+ int rtnl_set_link_name(sd_netlink **rtnl, int ifindex, const char *name) {
+         _cleanup_(sd_netlink_message_unrefp) sd_netlink_message *message = NULL;
++        _cleanup_strv_free_ char **alternative_names = NULL;
+         int r;
+ 
+         assert(rtnl);
+@@ -24,6 +25,18 @@ int rtnl_set_link_name(sd_netlink **rtnl, int ifindex, const char *name) {
+                         return r;
+         }
+ 
++        r = rtnl_get_link_alternative_names(rtnl, ifindex, &alternative_names);
++        if (r < 0)
++                log_debug_errno(r, "Failed to get alternative names on network interface %i, ignoring: %m",
++                                ifindex);
++
++        if (strv_contains(alternative_names, name)) {
++                r = rtnl_delete_link_alternative_names(rtnl, ifindex, STRV_MAKE(name));
++                if (r < 0)
++                        return log_debug_errno(r, "Failed to remove '%s' from alternative names on network interface %i: %m",
++                                               name, ifindex);
++        }
++
+         r = sd_rtnl_message_new_link(*rtnl, &message, RTM_SETLINK, ifindex);
+         if (r < 0)
+                 return r;
diff --git a/debian/patches/lp2002445-netlink-introduce-rtnl_get-delete_link_alternative_names.patch b/debian/patches/lp2002445-netlink-introduce-rtnl_get-delete_link_alternative_names.patch
new file mode 100644
index 0000000..93094eb
--- /dev/null
+++ b/debian/patches/lp2002445-netlink-introduce-rtnl_get-delete_link_alternative_names.patch
@@ -0,0 +1,102 @@
+From: Yu Watanabe <[e-mail]>
+Date: Fri, 17 Jul 2020 21:29:13 +0900
+Subject: netlink: introduce rtnl_get/delete_link_alternative_names()
+
+Origin: upstream, https://github.com/systemd/systemd/commit/14982526145de84201c7e3b4fc6be6aa5e9a08f7
+Bug-Ubuntu: https://launchpad.net/bugs/2002445
+
+---
+ src/libsystemd/sd-netlink/netlink-util.c | 45 ++++++++++++++++++++++++++++++--
+ src/libsystemd/sd-netlink/netlink-util.h |  2 ++
+ 2 files changed, 45 insertions(+), 2 deletions(-)
+
+diff --git a/src/libsystemd/sd-netlink/netlink-util.c b/src/libsystemd/sd-netlink/netlink-util.c
+index 7387cff..83f2a9b 100644
+--- a/src/libsystemd/sd-netlink/netlink-util.c
++++ b/src/libsystemd/sd-netlink/netlink-util.c
+@@ -85,12 +85,45 @@ int rtnl_set_link_properties(sd_netlink **rtnl, int ifindex, const char *alias,
+         return 0;
+ }
+ 
+-int rtnl_set_link_alternative_names(sd_netlink **rtnl, int ifindex, char * const *alternative_names) {
++int rtnl_get_link_alternative_names(sd_netlink **rtnl, int ifindex, char ***ret) {
++        _cleanup_(sd_netlink_message_unrefp) sd_netlink_message *message = NULL, *reply = NULL;
++        _cleanup_strv_free_ char **names = NULL;
++        int r;
++
++        assert(rtnl);
++        assert(ifindex > 0);
++        assert(ret);
++
++        if (!*rtnl) {
++                r = sd_netlink_open(rtnl);
++                if (r < 0)
++                        return r;
++        }
++
++        r = sd_rtnl_message_new_link(*rtnl, &message, RTM_GETLINK, ifindex);
++        if (r < 0)
++                return r;
++
++        r = sd_netlink_call(*rtnl, message, 0, &reply);
++        if (r < 0)
++                return r;
++
++        r = sd_netlink_message_read_strv(reply, IFLA_PROP_LIST, IFLA_ALT_IFNAME, &names);
++        if (r < 0 && r != -ENODATA)
++                return r;
++
++        *ret = TAKE_PTR(names);
++
++        return 0;
++}
++
++static int rtnl_update_link_alternative_names(sd_netlink **rtnl, uint16_t nlmsg_type, int ifindex, char * const *alternative_names) {
+         _cleanup_(sd_netlink_message_unrefp) sd_netlink_message *message = NULL;
+         int r;
+ 
+         assert(rtnl);
+         assert(ifindex > 0);
++        assert(IN_SET(nlmsg_type, RTM_NEWLINKPROP, RTM_DELLINKPROP));
+ 
+         if (strv_isempty(alternative_names))
+                 return 0;
+@@ -101,7 +134,7 @@ int rtnl_set_link_alternative_names(sd_netlink **rtnl, int ifindex, char * const
+                         return r;
+         }
+ 
+-        r = sd_rtnl_message_new_link(*rtnl, &message, RTM_NEWLINKPROP, ifindex);
++        r = sd_rtnl_message_new_link(*rtnl, &message, nlmsg_type, ifindex);
+         if (r < 0)
+                 return r;
+ 
+@@ -124,6 +157,14 @@ int rtnl_set_link_alternative_names(sd_netlink **rtnl, int ifindex, char * const
+         return 0;
+ }
+ 
++int rtnl_set_link_alternative_names(sd_netlink **rtnl, int ifindex, char * const *alternative_names) {
++        return rtnl_update_link_alternative_names(rtnl, RTM_NEWLINKPROP, ifindex, alternative_names);
++}
++
++int rtnl_delete_link_alternative_names(sd_netlink **rtnl, int ifindex, char * const *alternative_names) {
++        return rtnl_update_link_alternative_names(rtnl, RTM_DELLINKPROP, ifindex, alternative_names);
++}
++
+ int rtnl_set_link_alternative_names_by_ifname(sd_netlink **rtnl, const char *ifname, char * const *alternative_names) {
+         _cleanup_(sd_netlink_message_unrefp) sd_netlink_message *message = NULL;
+         int r;
+diff --git a/src/libsystemd/sd-netlink/netlink-util.h b/src/libsystemd/sd-netlink/netlink-util.h
+index d2d8334..33f36ec 100644
+--- a/src/libsystemd/sd-netlink/netlink-util.h
++++ b/src/libsystemd/sd-netlink/netlink-util.h
+@@ -49,8 +49,10 @@ static inline bool rtnl_message_type_is_qdisc(uint16_t type) {
+ 
+ int rtnl_set_link_name(sd_netlink **rtnl, int ifindex, const char *name);
+ int rtnl_set_link_properties(sd_netlink **rtnl, int ifindex, const char *alias, const struct ether_addr *mac, uint32_t mtu);
++int rtnl_get_link_alternative_names(sd_netlink **rtnl, int ifindex, char ***ret);
+ int rtnl_set_link_alternative_names(sd_netlink **rtnl, int ifindex, char * const *alternative_names);
+ int rtnl_set_link_alternative_names_by_ifname(sd_netlink **rtnl, const char *ifname, char * const *alternative_names);
++int rtnl_delete_link_alternative_names(sd_netlink **rtnl, int ifindex, char * const *alternative_names);
+ int rtnl_resolve_link_alternative_name(sd_netlink **rtnl, const char *name);
+ int rtnl_get_link_iftype(sd_netlink **rtnl, int ifindex, unsigned short *ret);
+ 
diff --git a/debian/patches/lp2002445-sd-netlink-restore-altname-on-error-in-rtnl_set_link_name.patch b/debian/patches/lp2002445-sd-netlink-restore-altname-on-error-in-rtnl_set_link_name.patch
new file mode 100644
index 0000000..baca7b2
--- /dev/null
+++ b/debian/patches/lp2002445-sd-netlink-restore-altname-on-error-in-rtnl_set_link_name.patch
@@ -0,0 +1,64 @@
+From: Nick Rosbrook <[e-mail]>
+Date: Wed, 2 Nov 2022 05:36:14 -0400
+Subject: sd-netlink: restore altname on error in rtnl_set_link_name
+
+Origin: upstream, https://github.com/systemd/systemd/commit/4d600667f8
+Bug-Ubuntu: https://launchpad.net/bugs/2002445
+
+If a current alternative name is to be used to rename a network
+interface, the alternative name must be removed first. If interface
+renaming fails, restore the alternative name that was deleted if
+necessary.
+---
+ src/libsystemd/sd-netlink/netlink-util.c | 19 ++++++++++++++++---
+ 1 file changed, 16 insertions(+), 3 deletions(-)
+
+diff --git a/src/libsystemd/sd-netlink/netlink-util.c b/src/libsystemd/sd-netlink/netlink-util.c
+index 502ea41..828203b 100644
+--- a/src/libsystemd/sd-netlink/netlink-util.c
++++ b/src/libsystemd/sd-netlink/netlink-util.c
+@@ -10,6 +10,7 @@
+ int rtnl_set_link_name(sd_netlink **rtnl, int ifindex, const char *name) {
+         _cleanup_(sd_netlink_message_unrefp) sd_netlink_message *message = NULL;
+         _cleanup_strv_free_ char **alternative_names = NULL;
++        bool altname_deleted = false;
+         int r;
+ 
+         assert(rtnl);
+@@ -29,21 +30,33 @@ int rtnl_set_link_name(sd_netlink **rtnl, int ifindex, const char *name) {
+                 if (r < 0)
+                         return log_debug_errno(r, "Failed to remove '%s' from alternative names on network interface %i: %m",
+                                                name, ifindex);
++
++                altname_deleted = true;
+         }
+ 
+         r = sd_rtnl_message_new_link(*rtnl, &message, RTM_SETLINK, ifindex);
+         if (r < 0)
+-                return r;
++                goto fail;
+ 
+         r = sd_netlink_message_append_string(message, IFLA_IFNAME, name);
+         if (r < 0)
+-                return r;
++                goto fail;
+ 
+         r = sd_netlink_call(*rtnl, message, 0, NULL);
+         if (r < 0)
+-                return r;
++                goto fail;
+ 
+         return 0;
++
++fail:
++        if (altname_deleted) {
++                int q = rtnl_set_link_alternative_names(rtnl, ifindex, STRV_MAKE(name));
++                if (q < 0)
++                        log_debug_errno(q, "Failed to restore '%s' as an alternative name on network interface %i, ignoring: %m",
++                                        name, ifindex);
++        }
++
++        return r;
+ }
+ 
+ int rtnl_set_link_properties(sd_netlink **rtnl, int ifindex, const char *alias,
diff --git a/debian/patches/lp2002445-udev-attempt-device-rename-even-if-interface-is-up.patch b/debian/patches/lp2002445-udev-attempt-device-rename-even-if-interface-is-up.patch
new file mode 100644
index 0000000..5f74018
--- /dev/null
+++ b/debian/patches/lp2002445-udev-attempt-device-rename-even-if-interface-is-up.patch
@@ -0,0 +1,38 @@
+From: Nick Rosbrook <[e-mail]>
+Date: Tue, 14 Feb 2023 15:56:38 -0500
+Subject: udev: attempt device rename even if interface is up
+
+Origin: upstream, https://github.com/systemd/systemd/commit/53584e7b61
+Bug-Ubuntu: https://launchpad.net/bugs/2002445
+
+Currently rename_netif() will not attempt to rename a device if it is
+already up, because the kernel will return -EBUSY unless live renaming
+is allowed on the device. This restriction will be removed in a future
+kernel version [1].
+
+To cover both cases, always attempt to rename the interface and return 0
+if we get -EBUSY.
+
+[1] https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=bd039b5ea2a9
+
+(modified to apply to v245.4)
+---
+ src/udev/udev-event.c | 5 +++++
+ 1 file changed, 5 insertions(+)
+
+diff --git a/src/udev/udev-event.c b/src/udev/udev-event.c
+index eb51139..dae485b 100644
+--- a/src/udev/udev-event.c
++++ b/src/udev/udev-event.c
+@@ -835,6 +835,11 @@ static int rename_netif(UdevEvent *event) {
+                 return log_device_error_errno(dev, r, "Failed to get ifindex: %m");
+ 
+         r = rtnl_set_link_name(&event->rtnl, ifindex, event->name);
++        if (r == -EBUSY) {
++                log_device_info(dev, "Network interface '%s' is already up, cannot rename to '%s'.",
++                                oldname, event->name);
++                return 0;
++        }
+         if (r < 0)
+                 return log_device_error_errno(dev, r, "Failed to rename network interface %i from '%s' to '%s': %m",
+                                               ifindex, oldname, event->name);
diff --git a/debian/patches/lp2002445-udev-net-allow-new-link-name-as-an-altname-before-renamin.patch b/debian/patches/lp2002445-udev-net-allow-new-link-name-as-an-altname-before-renamin.patch
new file mode 100644
index 0000000..a1aa00a
--- /dev/null
+++ b/debian/patches/lp2002445-udev-net-allow-new-link-name-as-an-altname-before-renamin.patch
@@ -0,0 +1,36 @@
+From: Nick Rosbrook <[e-mail]>
+Date: Wed, 2 Nov 2022 11:05:01 -0400
+Subject: udev/net: allow new link name as an altname before renaming happens
+
+Origin: upstream, https://github.com/systemd/systemd/commit/d0b31efc1a
+Bug-Ubuntu: https://launchpad.net/bugs/2002445
+
+When configuring a link's alternative names, the link's new name to-be
+is not allowed to be included because interface renaming will fail if
+the new name is already present as an alternative name. However,
+rtnl_set_link_name will delete the conflicting alternative name before
+renaming the device, if necessary.
+
+Allow the new link name to be set as an alternative name before the
+device is renamed. This means that if the rename is later skipped (i.e.
+because the link is already up), then the name can at least still be
+present as an alternative name.
+
+(modified to apply to v245.5)
+---
+ src/udev/net/link-config.c | 2 --
+ 1 file changed, 2 deletions(-)
+
+diff --git a/src/udev/net/link-config.c b/src/udev/net/link-config.c
+index 4d08bce..26c4a02 100644
+--- a/src/udev/net/link-config.c
++++ b/src/udev/net/link-config.c
+@@ -536,8 +536,6 @@ int link_config_apply(link_config_ctx *ctx, link_config *config,
+                         }
+                 }
+ 
+-        if (new_name)
+-                strv_remove(altnames, new_name);
+         strv_remove(altnames, old_name);
+         strv_uniq(altnames);
+         strv_sort(altnames);
diff --git a/debian/patches/series b/debian/patches/series
index 75dbc03..bae1736 100644
--- a/debian/patches/series
+++ b/debian/patches/series
@@ -185,3 +185,9 @@ lp1945225/0001-udev-net_id-parse-_SUN-ACPI-index-as-a-signed-intege.patch
 lp1945225/0002-udev-net_id-don-t-generate-slot-based-names-if-multi.patch
 lp1945225/0003-net_id-fix-newly-added-naming-scheme-name.patch
 lp1945225/0004-Add-remaining-supported-schemes-as-options-for-defau.patch
+lp2002445-udev-net-allow-new-link-name-as-an-altname-before-renamin.patch
+lp2002445-netlink-introduce-rtnl_get-delete_link_alternative_names.patch
+lp2002445-netlink-do-not-fail-when-new-interface-name-is-already-us.patch
+lp2002445-sd-netlink-restore-altname-on-error-in-rtnl_set_link_name.patch
+lp2002445-udev-attempt-device-rename-even-if-interface-is-up.patch
+lp1933090-test-seccomp-accept-ENOSYS-from-sysctl-2-too.patch
diff --git a/debian/tests/boot-and-services b/debian/tests/boot-and-services
index d78a055..6090569 100755
--- a/debian/tests/boot-and-services
+++ b/debian/tests/boot-and-services
@@ -59,6 +59,11 @@ class ServicesTest(unittest.TestCase):
         # https://bugs.debian.org/926138
         if is_container:
             failed = [f for f in failed if 'e2scrub_reap.service' not in f]
+        # LP: #1991285
+        arch = subprocess.check_output(['dpkg', '--print-architecture'])
+        arch = arch.decode('utf-8').strip()
+        if arch == 'armhf':
+            failed = [f for f in failed if 'systemd-remount-fs.service' not in f]
         if failed:
             for f in failed:
                 f = f.split()[0]