Merge ~enr0n/ubuntu/+source/systemd:ubuntu-kinetic into ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-kinetic

Proposed by Nick Rosbrook
Status: Merged
Merged at revision: 05c129f6ac0d419e87094b77d9f59963d3a8e700
Proposed branch: ~enr0n/ubuntu/+source/systemd:ubuntu-kinetic
Merge into: ~ubuntu-core-dev/ubuntu/+source/systemd:ubuntu-kinetic
Diff against target: 84 lines (+53/-0)
4 files modified
debian/changelog (+17/-0)
debian/patches/lp1991829-add-CAP_LINUX_IMMUTABLE-to-systemd-machined-so-it-ca.patch (+29/-0)
debian/patches/series (+1/-0)
debian/tests/upstream (+6/-0)
Reviewer Review Type Date Requested Status
Lukas Märdian Approve
Review via email: mp+431363@code.launchpad.net

Description of the change

To post a comment you must log in.
Revision history for this message
Lukas Märdian (slyon) wrote :

Thank you for the PPA test build and PPA autopkgtest run showing the mitigation of the problem.

LGTM!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 4740d17..c7ddcfc 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,20 @@
6+systemd (251.4-1ubuntu7) kinetic; urgency=medium
7+
8+ [ Nick Rosbrook ]
9+ * autopkgtest: do not allow qemu to be used on ppc64el (LP: #1992178)
10+ Almost every run on ppc64el takes 12 to 24 hours, so do this as a last
11+ resort to relieve pressure on autopkgtest infrastructure.
12+ File: debian/tests/upstream
13+ https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=5ab2b8ad13a3d7441935d6f43bb81fbd540e2c33
14+
15+ [ Dan Streetman ]
16+ * make machinectl read-only work (LP: #1991829)
17+ Author: Dan Streetman
18+ File: debian/patches/lp1991829-add-CAP_LINUX_IMMUTABLE-to-systemd-machined-so-it-ca.patch
19+ https://git.launchpad.net/~ubuntu-core-dev/ubuntu/+source/systemd/commit/?id=a8a41b11d712c8cfbf595d34f39d95096f23e202
20+
21+ -- Nick Rosbrook <nick.rosbrook@canonical.com> Tue, 11 Oct 2022 11:51:25 -0400
22+
23 systemd (251.4-1ubuntu6) kinetic; urgency=medium
24
25 * test: deny-list TEST-36-NUMAPOLICY on ppc64el (LP: #1989969)
26diff --git a/debian/patches/lp1991829-add-CAP_LINUX_IMMUTABLE-to-systemd-machined-so-it-ca.patch b/debian/patches/lp1991829-add-CAP_LINUX_IMMUTABLE-to-systemd-machined-so-it-ca.patch
27new file mode 100644
28index 0000000..d35aa0f
29--- /dev/null
30+++ b/debian/patches/lp1991829-add-CAP_LINUX_IMMUTABLE-to-systemd-machined-so-it-ca.patch
31@@ -0,0 +1,29 @@
32+From 137d162c42ed858613afc3d7493d08d4ae6d5c1b Mon Sep 17 00:00:00 2001
33+From: Dan Streetman <ddstreet@ieee.org>
34+Date: Fri, 16 Sep 2022 10:50:59 -0400
35+Subject: [PATCH] add CAP_LINUX_IMMUTABLE to systemd-machined, so it can handle
36+ machinectl read-only requests
37+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/systemd/+bug/1991829
38+Origin: upstream, https://github.com/systemd/systemd/pull/24697
39+
40+Without this, the 'machinectl read-only ...' command always fails.
41+---
42+ units/systemd-machined.service.in | 2 +-
43+ 1 file changed, 1 insertion(+), 1 deletion(-)
44+
45+diff --git a/units/systemd-machined.service.in b/units/systemd-machined.service.in
46+index e92f436dfd..d3f8abd9e4 100644
47+--- a/units/systemd-machined.service.in
48++++ b/units/systemd-machined.service.in
49+@@ -18,7 +18,7 @@ RequiresMountsFor=/var/lib/machines
50+
51+ [Service]
52+ BusName=org.freedesktop.machine1
53+-CapabilityBoundingSet=CAP_KILL CAP_SYS_PTRACE CAP_SYS_ADMIN CAP_SETGID CAP_SYS_CHROOT CAP_DAC_READ_SEARCH CAP_DAC_OVERRIDE CAP_CHOWN CAP_FOWNER CAP_FSETID CAP_MKNOD
54++CapabilityBoundingSet=CAP_KILL CAP_SYS_PTRACE CAP_SYS_ADMIN CAP_SETGID CAP_SYS_CHROOT CAP_DAC_READ_SEARCH CAP_DAC_OVERRIDE CAP_CHOWN CAP_FOWNER CAP_FSETID CAP_MKNOD CAP_LINUX_IMMUTABLE
55+ ExecStart={{ROOTLIBEXECDIR}}/systemd-machined
56+ IPAddressDeny=any
57+ LockPersonality=yes
58+--
59+2.34.1
60+
61diff --git a/debian/patches/series b/debian/patches/series
62index f85c48e..5b33e52 100644
63--- a/debian/patches/series
64+++ b/debian/patches/series
65@@ -51,3 +51,4 @@ test-copy-libgcc_s.so.1-to-TPM2-test-image-on-Debian-like.patch
66 lp1981042-core-firstboot-workaround-timezone-issues-caused-by-Ubunt.patch
67 test-denylist-TEST-29-PORTABLE-again.patch
68 lp1989969-test-deny-list-TEST-36-NUMAPOLICY-on-ppc64el.patch
69+lp1991829-add-CAP_LINUX_IMMUTABLE-to-systemd-machined-so-it-ca.patch
70diff --git a/debian/tests/upstream b/debian/tests/upstream
71index f05f14c..0d60a21 100755
72--- a/debian/tests/upstream
73+++ b/debian/tests/upstream
74@@ -24,4 +24,10 @@ export TEST_SHOW_JOURNAL=warning
75 export TEST_REQUIRE_INSTALL_TESTS=0
76 export TEST_PREFER_NSPAWN=1
77 export NO_BUILD=1
78+
79+# Temporarily disable tests running in QEMU on ppc64el (LP: #1992178)
80+if [ "$DPKGARCH" = "ppc64el" ]; then
81+ export TEST_NO_QEMU=1
82+fi
83+
84 test/run-integration-tests.sh

Subscribers

People subscribed via source and target branches