Code review comment for ~enr0n/+git/systemd-hwe:main

Revision history for this message
Lukas Märdian (slyon) wrote :

Thank you very much for addressing my concerns and explaining + extending the test case.

LGTM!

I talked to Łukasz about how to best get this into Kinetic (being a new package):
Could you please create a tracking bug on Launchpad (against the "ubuntu" component, i.e.: https://bugs.launchpad.net/ubuntu/+filebug) briefly describing the rational of this new package.

This bug reference should then be closed form debian/changelog, e.g.:
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,6 +1,6 @@
-systemd-hwe (251.2.1) UNRELEASED; urgency=medium
+systemd-hwe (251.2.1) kinetic; urgency=medium

- * Initial release.
+ * Initial release. (LP: #XXX)
   * Add hwdb.d/90-hwe-ubuntu.hwdb as a placeholder, and to serve as
     documentation.
   * Add a build-time test to check for duplicate rules between

Please feel free to push that change to the git repo directly. I'm happy to sponsor this package into Kinetic's NEW queue afterwards, for any archive-admin to pick up on.

review: Approve

« Back to merge proposal