Merge ~emitorino/ubuntu-cve-tracker:add_external_subprojects_metadata_validation into ubuntu-cve-tracker:master

[Emilia Torino]

- cve_lib.py: validate external subprojects metadata

In https://code.launchpad.net/~litios/ubuntu-cve-tracker/+git/ubuntu-cve-tracker/+merge/449839, the new subprojects's structure was added, but there validations were disabled since the data was not yet present.

We are now ready to enable this validation.

[Alex Murray (alexmurray)]

LGTM! Thanks Emi.

review: Approve

diff --git a/scripts/cve_lib.py b/scripts/cve_lib.py
index 272ec36..fe5b889 100755
--- a/scripts/cve_lib.py
+++ b/scripts/cve_lib.py
@@ -963,13 +963,12 @@ def load_external_subprojects():
         main_config = read_external_subproject_config(subproject_path)
         support_metadata = {}
 
-        # Disable this check until we have the information available
-        # for key in MANDATORY_EXTERNAL_SUBPROJECT_KEYS:
-        #     if key not in main_config:
-        #         print('%s missing "%s" field.' % (subproject_path, key))
-        #         raise ValueError
-        #     else:
-        #         support_metadata[key] = main_config[key]
+        for key in MANDATORY_EXTERNAL_SUBPROJECT_KEYS:
+            if key not in main_config:
+                print('%s missing "%s" field.' % (subproject_path, key))
+                raise ValueError
+            else:
+                support_metadata[key] = main_config[key]
 
         for ppa in main_config['ppas']:
             config = main_config['ppas'][ppa]