Merge ~emitorino/ubuntu-cve-tracker:add_project_yml_when_loading_subproject into ubuntu-cve-tracker:master
Proposed by
Emilia Torino
Status: | Merged |
---|---|
Merged at revision: | eaf926f8d3b7d08850bebd5c8af90aaac2cfdea2 |
Proposed branch: | ~emitorino/ubuntu-cve-tracker:add_project_yml_when_loading_subproject |
Merge into: | ubuntu-cve-tracker:master |
Diff against target: |
70 lines (+39/-5) 2 files modified
scripts/cve_lib.py (+18/-5) scripts/test_cve_lib.py (+21/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alex Murray | Approve | ||
Review via email: mp+440781@code.launchpad.net |
Commit message
For the purpose of improving the management of subprojects, adding support to load the project.yml information into subprojects. Unless missed, it seems cve_lib is not yet doing this.
Also, checking configs before setting them into subprojects, otherwise if a given config is not available, the KeyError exception is catch for the first config not found, and the following ones are not loaded at all.
Description of the change
* cve_lib.py:
- check config before trying to assign it to subprojects[rel]
- load customer metadata from project.yml into subprojects[rel]
* test_cve_lib:
- test for changes
To post a comment you must log in.
LGTM - thanks Emi (in particular thanks for the unit test - very nice!)