Merge ~emitorino/ubuntu-cve-tracker:fix_pocket_assignment_into_publish_usn_to_website_api into ubuntu-cve-tracker:master

[Emilia Torino]

- fixing pocket info not being properly assigned

After the latest changes introduced to support setting pocket into USNs, the publish-usn-to-website-api.py fails with:

$ $UCT/scripts/publish-usn-to-website-api.py --action update --json ~/development/esm_beta_support/usn_json/4811-1.json
Traceback (most recent call last):
  File "/home/emitorino/development/ubuntu-cve-tracker/scripts/publish-usn-to-website-api.py", line 196, in <module>
    release_packages[codename]["pocket"] = info["pocket"]
TypeError: list indices must be integers or slices, not str

This is because info["pocket"] is incorrectly being assigned to the release_packages[codename] list and should be set inside the earlier generated dict instead.

[Paulo Flabiano Smorigo (pfsmorigo)]

LGTM

[Steve Beattie (sbeattie)]

Nice catch, thanks for fixing. Merging/

review: Approve

diff --git a/scripts/publish-usn-to-website-api.py b/scripts/publish-usn-to-website-api.py
index bdc1c39..d876eef 100755
--- a/scripts/publish-usn-to-website-api.py
+++ b/scripts/publish-usn-to-website-api.py
@@ -183,17 +183,18 @@ for notice_id, notice in payload:
             else:
                 source_link = ""
                 version_link = ""
-            release_packages[codename].append(
-                {
+            release_package_info = {
                     "name": name,
                     "version": info["version"],
                     "is_source": "false",
                     "source_link": source_link,
                     "version_link": version_link,
                 }
-            )
             if "pocket" in info:
-                release_packages[codename]["pocket"] = info["pocket"]
+                release_package_info["pocket"] = info["pocket"]
+
+            release_packages[codename].append(release_package_info)
+
     # format CVEs and references
     cves = []
     references = []