Merge lp:~emilien-klein/lernid/event-combobox-enter into lp:lernid

[Emilien Klein]

[Emilien Klein (emilien-klein)]

Fixes the fact that you couldn't validate the connection popup by pressing Enter when the event combobox had the focus. Also reverting rev 140 (give focus to nickname entry textbox)

[Sanne Wouda (snnw)]

Thank you for working on this, Emilien. But I'm not sure if it's a good thing to change the behavior of a standard widget. IMHO with rev 140, everything works as a normal user would expect.

[Emilien Klein (emilien-klein)]

Well, I don't agree that giving the focus to the second element is what a normal user would expect.

In case you don't want to change the behavior of a standard widget (and I respect your opinion), then you should at least put the nickname textbox at the first place, on top of the event selection combobox. Otherwise you risk confusing users that will try to use the up/down arrow thinking that the combobox has the focus, before realizing that it's actually the textbox that has it.

[Michael Budde (mbudde)]

I agree that giving the second widget focus is not good usability but I can also see Sannes point that changing the behavior of a widget is not such a good idea. Users could be used to using enter to activate the combo box. So based on that, I think we should go for moving the two around.

review: Disapprove

Unmerged revisions

141. By Emilien Klein on 2010-01-29

Make the event combobox generate the default event when pressed Enter. (LP #513978)
Revert giving focus to the nickname textbox (rev 140)

=== modified file 'data/ui/ConnectDialog.ui'
--- data/ui/ConnectDialog.ui	2010-01-29 13:31:52 +0000
+++ data/ui/ConnectDialog.ui	2010-01-29 19:29:11 +0000
@@ -69,6 +69,7 @@
                   <object class="GtkComboBox" id="event_combo">
                     <property name="visible">True</property>
                     <signal name="changed" handler="check_ready_to_connect"/>
+                    <signal name="key_press_event" handler="combo_key_pressed"/>
                   </object>
                   <packing>
                     <property name="left_attach">1</property>
@@ -80,7 +81,6 @@
                   <object class="GtkEntry" id="nick_textentry">
                     <property name="visible">True</property>
                     <property name="can_focus">True</property>
-                    <property name="has_focus">True</property>
                     <property name="invisible_char">&#x25CF;</property>
                     <property name="activates_default">True</property>
                     <signal name="changed" handler="check_ready_to_connect"/>

=== modified file 'lernid/ConnectDialog.py'
--- lernid/ConnectDialog.py	2010-01-28 14:51:52 +0000
+++ lernid/ConnectDialog.py	2010-01-29 19:29:11 +0000
@@ -90,6 +90,15 @@
         else:
             self.builder.get_object("button_connect").set_sensitive(False)
 
+    def combo_key_pressed(self, widget, event):
+        """combo_key_pressed - The user has pressed a key.
+        If it is the enter key, then generate the default event
+        """
+        if event.keyval == gtk.keysyms.Return:
+            self.ok(widget, None)
+            # As if the default button had been pressed
+            self.emit('response', gtk.RESPONSE_OK)
+
     def get_nick(self):
         return self.builder.get_object('nick_textentry').get_text()