Merge lp:~emailgirishrawat/ubuntu-weather-app/markdown-readmes into lp:ubuntu-weather-app
Status: | Merged |
---|---|
Approved by: | Victor Thompson on 2015-12-22 |
Approved revision: | 191 |
Merged at revision: | 188 |
Proposed branch: | lp:~emailgirishrawat/ubuntu-weather-app/markdown-readmes |
Merge into: | lp:ubuntu-weather-app |
Diff against target: |
437 lines (+272/-114) 9 files modified
README (+0/-20) README-Autopilot.md (+78/-0) README-Developers.md (+91/-0) README-Mergeproposal.md (+30/-0) README-Translations.md (+35/-0) README.autopilot (+0/-57) README.md (+34/-0) README.translations (+0/-37) debian/changelog (+4/-0) |
To merge this branch: | bzr merge lp:~emailgirishrawat/ubuntu-weather-app/markdown-readmes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jenkins Bot | continuous-integration | Approve on 2015-12-22 | |
Victor Thompson | Approve on 2015-12-22 | ||
Andrew Hayzen | Approve on 2015-12-21 | ||
Nicholas Skaggs (community) | 2015-12-17 | Approve on 2015-12-17 | |
Review via email:
|
Commit message
Updated and fixed READMEs.
Description of the change
Marked down all the READMEs. Minor changes in README-
Nicholas Skaggs (nskaggs) wrote : | # |
Victor Thompson (vthompson) wrote : | # |
Hi Girish! Thanks for helping to get these updated! Good work! I have some inline comments that I'd like you too look into, please.
One general question for Andrew and Nicholas (and others): Should we perhaps remove the section on debugging with GDB? It doesn't seem as applicable for a pure QML app--I've never had to run gdb while running a QML app.
Andrew Hayzen (ahayzen) wrote : | # |
Looking pretty good so far, a few (8) inline comments :-)
Girish (emailgirishrawat) wrote : | # |
ahayzen : vthompson : Fixed.
ahayzen : I couldn't find a wiki for the weather app's design specs.
Andrew Hayzen (ahayzen) wrote : | # |
One inline comment
1) We now have (or popey is adding as we speak :-) ) https:/
Girish (emailgirishrawat) wrote : | # |
Andrew, the link to design leads to the main page. It's doesn't even lead to the design section on the page.
Nevertheless, I've made the changes.
Andrew Hayzen (ahayzen) wrote : | # |
LGTM, thanks for your patience and great work :-) I'll let Victor also approve before it is merged in.
FAILED: Autolanding.
No commit message was specified in the merge proposal. Hit 'Add commit message' on the merge proposal web page or follow the link below. You can approve the merge proposal yourself to rerun.
https:/
Girish (emailgirishrawat) wrote : | # |
Victor: Could you approve this again? Forgot to add a commit message the previous time.
I'll leave the final approval to Andrew, but this looks like a nice improvement.