Merge lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs into lp:ubuntu-docviewer-app
Proposed by
Girish
Status: | Merged |
---|---|
Approved by: | Stefano Verzegnassi |
Approved revision: | 236 |
Merged at revision: | 238 |
Proposed branch: | lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs |
Merge into: | lp:ubuntu-docviewer-app |
Diff against target: |
346 lines (+229/-75) 8 files modified
README (+0/-39) README-Autopilot.md (+81/-0) README-Developers.md (+43/-0) README-Mergeproposal.md (+32/-0) README-Translations.md (+37/-0) README.md (+30/-0) README.translations (+0/-36) debian/changelog (+6/-0) |
To merge this branch: | bzr merge lp:~emailgirishrawat/ubuntu-docviewer-app/READMEs |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Jenkins Bot | continuous-integration | Approve | |
Stefano Verzegnassi | Approve | ||
Review via email: mp+281013@code.launchpad.net |
Commit message
Updated and expanded READMEs.
Description of the change
Updated and expanded READMEs.
To post a comment you must log in.
Hi,
Thanks for this big improvement!
I had a look at your MP and overall it looks very good.
However, some minor change is required in order to reflect the current status of the project.
* Some of the Autopilot tests are currently broken. Mergeproposal. md' file, explaining that they aren't strictly required at the moment. The same goes for 'README- Autopilot. md' file.
It may be worth to point that out in the 'README-
* In the 'README- Developers. md' file, we mention that LibreOffice 5.0 is not available in the archive. This is no longer true, since it's available in Ubuntu 15.10 archives. libreoffice/ libreoffice- 5-0
For earlier release, we may want to refer to the following PPA, which includes only stable releases:
ppa:
* Still in the same file, in the 'Compiling" section, it may be useful to specify that a working internet connection is required in order to build the project, since a number of Debian packages are downloaded when the project is loaded the first time through (e.g.) QtCreator.
* Still a small correction to 'README- Mergeproposal' .
The line:
"Does the MP change the UI? If Yes, has it been approved by design?"
does not reflect our current workflow, since a large part of the UI hasn't been approved by the design team (it has been approved by the devs instead).
Please replace that line with:
"Does the MP change the UI? If Yes, has it been approved by design, or discussed with some of the DocViewer developers?"
Thanks again!