Merge lp:~elvisd79/ubuntu/oneiric/compiz-plugins-main/fix-for-772177 into lp:ubuntu/oneiric/compiz-plugins-main

Proposed by Elvis Dominguez on 2011-06-23
Status: Work in progress
Proposed branch: lp:~elvisd79/ubuntu/oneiric/compiz-plugins-main/fix-for-772177
Merge into: lp:ubuntu/oneiric/compiz-plugins-main
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
staticswitcher/staticswitcher.xml.in (+1/-1)
To merge this branch: bzr merge lp:~elvisd79/ubuntu/oneiric/compiz-plugins-main/fix-for-772177
Reviewer Review Type Date Requested Status
Didier Roche Disapprove on 2011-07-07
Robert Roth (community) Approve on 2011-06-24
Ubuntu branches 2011-06-23 Pending
Review via email: mp+65740@code.launchpad.net

Description of the change

set "Static Application Switcher/Default Popup Delay" option's default value to 0 instead of 0.2 (LP: #772177)

To post a comment you must log in.
Robert Roth (evfool) wrote :

Looks fine.

review: Approve
Didier Roche (didrocks) wrote :

Thanks for your contribution there.

However, as I already explained in another merge request asking for exactly the same change, setting the value to 0 is not the solution. Indeed, if you alt + tab between two applications very quickly, you will then see a flickering dialog appearing. The delay is there to prevent that and it was discussed in natty as part of a design decision.

Alt + Tab is still slow for other reason, not really linked to this 0s.

You should have a look at the other branch linked to the same bug that I rejected for the same reason. You have more explanation there as well :)
Thanks nevertheless, but think about reading all the available information please ;)

review: Disapprove

Unmerged revisions

14. By Elvis Dominguez on 2011-06-23

* staticswitcher/statisswitcher.xml.in
  - set "Default Popup Delay" option's default value to 0 instead of 0.2 (LP: #772177)

13. By Elvis Dominguez on 2011-06-23

Changed Static application Switcher delay to 0
LP:#772177

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-06-10 16:15:08 +0000
3+++ debian/changelog 2011-06-23 22:11:05 +0000
4@@ -1,3 +1,10 @@
5+compiz-plugins-main (0.9.4+bzr20110527-0ubuntu5) natty; urgency=low
6+
7+ * staticswitcher/statisswitcher.xml.in
8+ - set "Default Popup Delay" option's default value to 0 instead of 0.2 (LP: #772177)
9+
10+ -- Elvis Dominguez <elvisd79@gmail.com> Fri, 24 Jun 2011 00:05:11 +0200
11+
12 compiz-plugins-main (0.9.4+bzr20110527-0ubuntu4) oneiric; urgency=low
13
14 * debian/patches/01-animation-defaults.patch:
15
16=== modified file 'staticswitcher/staticswitcher.xml.in'
17--- staticswitcher/staticswitcher.xml.in 2011-04-07 14:21:07 +0000
18+++ staticswitcher/staticswitcher.xml.in 2011-06-23 22:11:05 +0000
19@@ -143,7 +143,7 @@
20 <option name="popup_delay" type="float">
21 <_short>Popup Window Delay</_short>
22 <_long>Time (in s) the popup window should be delayed before appearing</_long>
23- <default>0.2</default>
24+ <default>0</default>
25 <min>0.0</min>
26 <max>2.0</max>
27 <precision>0.05</precision>

Subscribers

People subscribed via source and target branches