Unity 8

Merge lp:~elopio/unity8/test_open_app_from_launcher into lp:unity8

test_open_app_from_launcher
Merge into trunk

Proposed by Leo Arias on 2014-07-01

Status:	Superseded
Proposed branch:	lp:~elopio/unity8/test_open_app_from_launcher
Merge into:	lp:unity8
Prerequisite:	lp:~elopio/unity8/test_open_dash
Diff against target:	62 lines (+28/-0) 4 files modified qml/Launcher/LauncherPanel.qml (+4/-0) tests/autopilot/unity8/application_lifecycle/tests/test_application_lifecycle.py (+7/-0) tests/autopilot/unity8/shell/emulators/launcher.py (+6/-0) tests/autopilot/unity8/shell/emulators/main_window.py (+11/-0)
To merge this branch:	bzr merge lp:~elopio/unity8/test_open_app_from_launcher
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
PS Jenkins bot (community)	continuous-integration		Approve on 2014-07-11
Albert Astals Cid (community)		2014-07-01	Needs Fixing on 2014-07-10
Review via email: mp+225112@code.launchpad.net

This proposal supersedes a proposal from 2014-07-01.

This proposal has been superseded by a proposal from 2014-07-21.

Commit message

Added an autopilot test for focusing an app clicking the icon on the launcher.

Description of the change

* Are there any related MPs required for this MP to build/function as expected? Please list.

Yes, the prerequisite has the helpers to open the dash.

* Did you perform an exploratory manual test run of your code change and any related functionality?

Sort of. I ran the tests. I inspected the tree a lot with autopilot vis. I checked the jenkins results.

* Did you make sure that your branch does not contain spurious tags?

Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

No debian changes.

* If you changed the UI, has there been a design review?

No UI changes, but I added a new property to the LauncherDelegate to make the appId accessible by autopilot.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-01:

FAILED: Continuous integration, rev:992
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~elopio/unity8/test_open_app_from_launcher/+merge/225112/+edit-commit-message

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3277/rebuild

review: Needs Fixing (continuous-integration)

lp:~elopio/unity8/test_open_app_from_launcher updated on 2014-07-09

993. By Leo Arias on 2014-07-09: Merged with prerequisite.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3373/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3374/rebuild

review: Approve (continuous-integration)

lp:~elopio/unity8/test_open_app_from_launcher updated on 2014-07-09

994. By Leo Arias on 2014-07-09: Moved the property to the delegate as suggested by michael.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-09:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3383/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

Albert Astals Cid (aacid) wrote on 2014-07-10:

Text conflict in tests/autopilot/unity8/shell/emulators/main_window.py
1 conflicts encountered.

review: Needs Fixing

lp:~elopio/unity8/test_open_app_from_launcher updated on 2014-07-10

995. By Leo Arias on 2014-07-09: Merged with prerequisite.
996. By Leo Arias on 2014-07-10: Merged with prerequisite.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-10:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3391/rebuild

review: Needs Fixing (continuous-integration)

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2014-07-11:

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3399/rebuild

review: Approve (continuous-integration)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

Subscribers

People subscribed via source and target branches

to all changes:

Leo Arias

Mohammad Rakibul Hasan

Unity Team

 === modified file 'qml/Launcher/LauncherPanel.qml'
 --- qml/Launcher/LauncherPanel.qml	2014-07-09 19:45:46 +0000
 +++ qml/Launcher/LauncherPanel.qml	2014-07-10 14:23:27 +0000
@@ -146,6 +146,10 @@
                      delegate: FoldingLauncherDelegate {
                          id: launcherDelegate
                          objectName: "launcherDelegate" + index
++                        // We need the appId in the delegate in order to find
++                        // the right app when running autopilot tests for
++                        // multiple apps.
++                        property string appId: model.appId
                          itemHeight: launcherListView.itemHeight
                          itemWidth: launcherListView.itemWidth
                          width: itemWidth
 === modified file 'tests/autopilot/unity8/application_lifecycle/tests/test_application_lifecycle.py'
 --- tests/autopilot/unity8/application_lifecycle/tests/test_application_lifecycle.py	2014-07-10 14:23:27 +0000
 +++ tests/autopilot/unity8/application_lifecycle/tests/test_application_lifecycle.py	2014-07-10 14:23:27 +0000
@@ -123,3 +123,10 @@
          self.main_window.show_dash_from_launcher()
          self.assert_current_focused_application('')
++
++    def test_click_app_icon_on_dash_must_focus_it(self):
++        application_name = self.launch_fake_app()
++        self.main_window.show_dash_from_launcher()
++
++        self.main_window.launch_application(application_name)
++        self.assert_current_focused_application(application_name)
 === modified file 'tests/autopilot/unity8/shell/emulators/launcher.py'
 --- tests/autopilot/unity8/shell/emulators/launcher.py	2014-07-10 14:23:27 +0000
 +++ tests/autopilot/unity8/shell/emulators/launcher.py	2014-07-10 14:23:27 +0000
@@ -57,3 +57,9 @@
              self.pointing_device.click_object(dash_icon)
          else:
              raise emulators.UnityEmulatorException('The launcher is closed.')
++
++    @autopilot.logging.log_action(logger.debug)
++    def click_application_launcher_icon(self, application_name):
++        launcher_delegate = self.select_single(
++            'LauncherDelegate', appId=application_name)
++        self.pointing_device.click_object(launcher_delegate)
 === modified file 'tests/autopilot/unity8/shell/emulators/main_window.py'
 --- tests/autopilot/unity8/shell/emulators/main_window.py	2014-07-10 14:23:27 +0000
 +++ tests/autopilot/unity8/shell/emulators/main_window.py	2014-07-10 14:23:27 +0000
@@ -150,3 +150,14 @@
      def is_launcher_open(self):
          return self._get_launcher().shown
++
++    @autopilot_logging.log_action(logger.info)
++    def launch_application(self, application_name):
++        """Launch an application.
++
++        :parameter application_name: The name of the application to launch.
++
++        """
++        launcher = self.open_launcher()
++        launcher.click_application_launcher_icon(application_name)
++        self.get_current_focused_app_id().wait_for(application_name)