Merge lp:~elopio/unity8/revert_open_preview into lp:unity8
Proposed by
Leo Arias
Status: | Merged |
---|---|
Approved by: | Albert Astals Cid |
Approved revision: | 799 |
Merged at revision: | 814 |
Proposed branch: | lp:~elopio/unity8/revert_open_preview |
Merge into: | lp:unity8 |
Diff against target: |
55 lines (+12/-6) 2 files modified
tests/autopilot/unity8/shell/emulators/dash.py (+9/-1) tests/autopilot/unity8/shell/tests/test_emulators.py (+3/-5) |
To merge this branch: | bzr merge lp:~elopio/unity8/revert_open_preview |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Albert Astals Cid (community) | Approve | ||
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Richard Huddie (community) | Approve | ||
Review via email: mp+213771@code.launchpad.net |
Commit message
Reverted the open_preview autopilot helper to return a Preview object.
Description of the change
One of the most important things of the page object pattern[1] is that actions should return other page objects representing the state of the UI after the action if performed.
That's why the autopilot helper open_preview returns a Preview object.
With the new scope changes I didn't notice that this was changed to return a the list of previews. I'm reverting that here.
To post a comment you must log in.
FAILED: Continuous integration, rev:798 jenkins. qa.ubuntu. com/job/ unity8- ci/2709/ jenkins. qa.ubuntu. com/job/ generic- mediumtests- trusty/ 4443/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- trusty- touch/4043/ console jenkins. qa.ubuntu. com/job/ unity-phablet- qmluitests- trusty/ 1579/console jenkins. qa.ubuntu. com/job/ unity8- trusty- amd64-ci/ 1230/console jenkins. qa.ubuntu. com/job/ unity8- trusty- armhf-ci/ 1234/console jenkins. qa.ubuntu. com/job/ unity8- trusty- i386-ci/ 1230/console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- amd64/4549/ console jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- armhf/4076/ console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/unity8- ci/2709/ rebuild
http://