Merge lp:~elopio/unity8/fix1277591-open_scope_scrolling_waiting_for_wrong_property into lp:unity8

[Leo Arias]

On the autopilot helper to open a scope, wait for the dash content list to stop moving.

There are two sad things. One is that we can't properly test this fix as I don't know how to make the animation to last longer and actually check that autopilot slept the same amount of time it took for the animation to complete. I added this to my TODO, and I'll start asking around next week.
The other is that this doesn't fix the error we are getting on maguro.

* Are there any related MPs required for this MP to build/function as expected? No, there aren't.
 * Did you perform an exploratory manual test run of your code change and any related functionality? Yes, kind of. As I can't write a proper test for this fix, I put a pdb before the wait to make sure that the property is False, so we are actually waiting for something.
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP? No debian changes.
 * If you changed the UI, has there been a design review? No UI changes.

[Michael Terry (mterry)]

Looks reasonable. I'm not an expert on this piece of code, but the explanation and changes makes sense. Code still passes.

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 - Yes, I ran the autopilot suite, it still worked.
 * Did CI run pass? If not, please explain why.
 - Haven't run yet.

review: Approve

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:686
http://jenkins.qa.ubuntu.com/job/unity8-ci/2284/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3028
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/2758
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/1155
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/806
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/808
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/808/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/806
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/2664
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3030
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3030/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2759
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/2759/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5176
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/3767

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/2284/rebuild

review: Approve (continuous-integration)

=== modified file 'tests/autopilot/unity8/shell/emulators/dash.py'
--- tests/autopilot/unity8/shell/emulators/dash.py	2014-01-23 06:54:39 +0000
+++ tests/autopilot/unity8/shell/emulators/dash.py	2014-02-07 17:05:44 +0000
@@ -94,9 +94,9 @@
 
         while not scope_loader.isCurrent:
             scroll()
+            self.dash_content_list.moving.wait_for(False)
 
         scope = self._get_scope_from_loader(scope_loader)
-        scope.moving.wait_for(False)
         scope.isCurrent.wait_for(True)
         return scope