Merge lp:~elopio/unity-scope-click/update_new_scopes2 into lp:unity-scope-click/devel

Proposed by Leo Arias
Status: Merged
Approved by: dobey
Approved revision: 226
Merged at revision: 254
Proposed branch: lp:~elopio/unity-scope-click/update_new_scopes2
Merge into: lp:unity-scope-click/devel
Diff against target: 55 lines (+5/-6)
2 files modified
autopilot/unityclickscope/credentials.py (+1/-1)
autopilot/unityclickscope/test_click_scope.py (+4/-5)
To merge this branch: bzr merge lp:~elopio/unity-scope-click/update_new_scopes2
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
dobey (community) Approve
Review via email: mp+219528@code.launchpad.net

This proposal supersedes a proposal from 2014-05-14.

Commit message

Update autopilot tests for some changes in apps and unity8.

To post a comment you must log in.
Revision history for this message
dobey (dobey) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'autopilot/unityclickscope/credentials.py'
2--- autopilot/unityclickscope/credentials.py 2014-01-28 05:21:19 +0000
3+++ autopilot/unityclickscope/credentials.py 2014-05-14 13:36:30 +0000
4@@ -90,7 +90,7 @@
5 auth_data = account_service.get_auth_data()
6 identity = auth_data.get_credentials_id()
7 method = auth_data.get_method()
8- mechanism = auth_data.get_method()
9+ mechanism = auth_data.get_mechanism()
10 session_data = auth_data.get_parameters()
11 session = Signon.AuthSession.new(identity, method)
12 session.process(
13
14=== modified file 'autopilot/unityclickscope/test_click_scope.py'
15--- autopilot/unityclickscope/test_click_scope.py 2014-04-09 16:36:08 +0000
16+++ autopilot/unityclickscope/test_click_scope.py 2014-05-14 13:36:30 +0000
17@@ -107,7 +107,7 @@
18 logging.info('Restarting click scope.')
19 os.system('pkill -f -9 clickscope.ini')
20 lib_path = '/usr/lib/$DEB_HOST_MULTIARCH/'
21- scoperunner_path = os.path.join(lib_path, 'scoperunner/scoperunner')
22+ scoperunner_path = os.path.join(lib_path, 'unity-scopes/scoperunner')
23 clickscope_config_ini_path = os.path.join(
24 lib_path, 'unity-scopes/clickscope/clickscope.ini')
25 os.system(
26@@ -161,11 +161,11 @@
27 def test_search_available_app(self):
28 self.search('Shorts')
29 applications = self.scope.get_applications('appstore')
30- self.assertThat(applications[0].title, Equals('Shorts'))
31+ self.assertThat(applications[0], Equals('Shorts'))
32
33 def test_open_app_preview(self):
34 expected_details = dict(
35- title='Shorts', subtitle='Shorts is an rssreader application')
36+ title='Shorts', subtitle='Ubuntu Click Loader')
37 preview = self.open_app_preview('appstore', 'Shorts')
38 details = preview.get_details()
39 self.assertEqual(details, expected_details)
40@@ -182,14 +182,13 @@
41 class ClickScopeTestCaseWithCredentials(BaseClickScopeTestCase):
42
43 def setUp(self):
44- self.skipTest('segfaults. TODO in following branches.')
45+# self.skipTest('segfaults. TODO in following branches.')
46 self.add_u1_credentials()
47 super(ClickScopeTestCaseWithCredentials, self).setUp()
48 self.scope = self.open_scope()
49 self.preview = self.open_app_preview('appstore', 'Shorts')
50
51 def add_u1_credentials(self):
52- import pdb; pdb.set_trace()
53 account_manager = credentials.AccountManager()
54 account = account_manager.add_u1_credentials(
55 'dummy@example.com', 'dummy')

Subscribers

People subscribed via source and target branches

to all changes: