Merge lp:~elopio/unity-scope-click/autopilot-tests1 into lp:unity-scope-click

[Leo Arias]

Added a simple autopilot test that opens the scope.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:98
No commit message was specified in the merge proposal. Click on the following link and set the commit message (if you want a jenkins rebuild you need to trigger it yourself):
https://code.launchpad.net/~elopio/unity-scope-click/autopilot-tests1/+merge/200126/+edit-commit-message

http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/139/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-amd64-ci/37
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-armhf-ci/37

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/139/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

Waiting for the scope scrolling methods to be merged into unity:
https://code.launchpad.net/~elopio/unity8/open_scope/+merge/200426

[Richard Huddie (rhuddie)]

review: Approve

[Javier Collado (javier.collado)]

The code looks good, but I'm curious about why `dict` is being used instead of
a dictionary literal. Is not a big deal, but I'd like to be consistent with the
style being used in other tests when I write one in the future.

[Leo Arias (elopio)]

> The code looks good, but I'm curious about why `dict` is being used instead of
> a dictionary literal. Is not a big deal, but I'd like to be consistent with
> the
> style being used in other tests when I write one in the future.

Well, I just copied this from Unity. Unity has a private method _get_scenarios or something like that, but I prefer to have the scenarios we are testing listed explicitly.
About using 'dict', I prefer it this way but I have no real reason. If you don't have any reason or preference for using the {}, lets keep doing it this way.

[lp:~elopio/unity-scope-click/autopilot-tests1]

99. By Leo Arias on 2014-01-10

Updated to use unity helpers.

[Mike McCracken (mikemc)]

oops - copyright header says 2013

review: Needs Fixing

[lp:~elopio/unity-scope-click/autopilot-tests1]

100. By Leo Arias on 2014-01-10

Updated copyright year.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:99
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/155/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-amd64-ci/53
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-armhf-ci/53

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/155/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:100
http://jenkins.qa.ubuntu.com/job/unity-scope-click-ci/156/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-amd64-ci/54/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-scope-click-trusty-armhf-ci/54

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-scope-click-ci/156/rebuild

review: Needs Fixing (continuous-integration)

[Mike McCracken (mikemc)]

tests pass for me with current trunk of unity8 installed, then pointing these tests at the unity8 python autopilot modules manually, which I did because I was too lazy to figure out how to manually install that package:

PYTHONPATH=$PYTHONPATH:/home/mmccrack/src/unity8/trunk/tests/autopilot autopilot run unityclickscope

Thanks for tackling this, Leo!

review: Approve

[Mike McCracken (mikemc)]

note - my comment is about running on the desktop btw.

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== added directory 'src/tests'
=== added directory 'src/tests/autopilot'
=== added directory 'src/tests/autopilot/unityclickscope'
=== added file 'src/tests/autopilot/unityclickscope/__init__.py'
=== added file 'src/tests/autopilot/unityclickscope/test_click_scope.py'
--- src/tests/autopilot/unityclickscope/test_click_scope.py	1970-01-01 00:00:00 +0000
+++ src/tests/autopilot/unityclickscope/test_click_scope.py	2014-01-10 17:19:33 +0000
@@ -0,0 +1,42 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+#
+# Copyright (C) 2013, 2014 Canonical Ltd.
+#
+# This program is free software; you can redistribute it and/or modify
+# it under the terms of the GNU General Public License version 3, as published
+# by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program. If not, see <http://www.gnu.org/licenses/>.
+
+from autopilot.matchers import Eventually
+from testtools.matchers import Equals
+from unity8 import process_helpers
+from unity8.shell import tests as unity_tests
+
+
+class ScopeClickTestCase(unity_tests.UnityTestCase):
+
+    scenarios = [
+        ('Desktop Nexus 4', dict(
+            app_width=768, app_height=1280, grid_unit_px=18)),
+        ('Desktop Nexus 10',
+            dict(app_width=2560, app_height=1600, grid_unit_px=20))
+    ]
+
+    def setUp(self):
+        super(ScopeClickTestCase, self).setUp()
+        unity_proxy = self.launch_unity()
+        process_helpers.unlock_unity(unity_proxy)
+        self.dash = self.main_window.get_dash()
+        self.scope = self.dash.get_scope('applications')
+
+    def test_open_scope_scrolling(self):
+        self.assertFalse(self.scope.isCurrent)
+        self.dash.open_scope('applications')
+        self.assertThat(self.scope.isCurrent, Eventually(Equals(True)))