ubuntuone-testing

Merge lp:~elopio/ubuntuone-testing/multiwordparams into lp:ubuntuone-testing

  1. multiwordparams
  2. Merge into trunk
Proposed by Leo Arias
Status: Merged
Approved by: Leo Arias
Approved revision: 83
Merged at revision: 84
Proposed branch: lp:~elopio/ubuntuone-testing/multiwordparams
Merge into: lp:ubuntuone-testing
Diff against target: 19 lines (+2/-2)
2 files modified
bin/sst-remote (+1/-1)
bin/sst-run (+1/-1)
To merge this branch: bzr merge lp:~elopio/ubuntuone-testing/multiwordparams
Reviewer Review Type Date Requested Status
Leo Arias (community) Approve
Rick McBride (community) Approve
Review via email: mp+98241@code.launchpad.net

Commit message

Pass the parameters to SST in quotes, to allow multiple words in an argument.

Description of the change

We can't run tests on Internet Explorer because bash parses the parameter before sst. If we send the parameters quoted, this is possible.

This branch passes the sst parameters to python in quotes.

To post a comment you must log in.
Revision history for this message
Rick McBride (rmcbride) wrote :

That'll fix it!

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

Voting does not meet specified criteria. Required: Approve >= 1, Disapprove == 0, Needs Fixing == 0, Needs Information == 0, Resubmit == 0, Pending == 0. Got: 1 Approve, 1 Pending.

Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

Voting does not meet specified criteria. Required: Approve >= 1, Disapprove == 0, Needs Fixing == 0, Needs Information == 0, Resubmit == 0, Pending == 0. Got: 1 Approve, 1 Pending.

Revision history for this message
Leo Arias (elopio) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bin/sst-remote'
2--- bin/sst-remote 2011-09-27 18:48:05 +0000
3+++ bin/sst-remote 2012-03-19 17:54:29 +0000
4@@ -1,4 +1,4 @@
5 #!/bin/sh
6
7 export PYTHONPATH=lib:$PYTHONPATH
8-exec sourcecode/selenium-simple-test/sst-remote $@
9+exec sourcecode/selenium-simple-test/sst-remote "$@"
10
11=== modified file 'bin/sst-run'
12--- bin/sst-run 2011-09-27 18:48:05 +0000
13+++ bin/sst-run 2012-03-19 17:54:29 +0000
14@@ -1,4 +1,4 @@
15 #!/bin/sh
16
17 export PYTHONPATH=lib:$PYTHONPATH
18-exec sourcecode/selenium-simple-test/sst-run $@
19+exec sourcecode/selenium-simple-test/sst-run "$@"

Subscribers

People subscribed via source and target branches