Merge lp:~elopio/ubuntuone-testing/fix-1046476 into lp:ubuntuone-testing

Proposed by Leo Arias
Status: Merged
Approved by: Vincent Ladeuil
Approved revision: 123
Merged at revision: 124
Proposed branch: lp:~elopio/ubuntuone-testing/fix-1046476
Merge into: lp:ubuntuone-testing
Diff against target: 15 lines (+3/-3)
1 file modified
ubuntuone/web/tests/sst/shared/data/environment.py (+3/-3)
To merge this branch: bzr merge lp:~elopio/ubuntuone-testing/fix-1046476
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
Leo Arias (community) Approve
Review via email: mp+122923@code.launchpad.net

Commit message

Fix the files URLs

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

weird, why didn't get it caught earlier ? Is this code covered in tests ? If not, it may be worth adding a test. If yes, some test needs to be fixed no ?

I'm ok to land this with either a new test or a fixed one ;)

review: Needs Fixing
Revision history for this message
Leo Arias (elopio) wrote :

The files tests will fail because of this. But we didn't notice because jenkins was out of service. We might add a test just to open the main page, and hardcode the expected value. That's a good idea. I'll open a bug for that.

Revision history for this message
Leo Arias (elopio) :
review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

Voting does not meet specified criteria. Required: Approve >= 1, Disapprove == 0, Needs Fixing == 0, Needs Information == 0, Resubmit == 0, Pending == 0. Got: 1 Approve, 1 Needs Fixing.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Looks like I need to vote approve now to unblock this ?

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntuone/web/tests/sst/shared/data/environment.py'
2--- ubuntuone/web/tests/sst/shared/data/environment.py 2012-08-14 16:17:45 +0000
3+++ ubuntuone/web/tests/sst/shared/data/environment.py 2012-09-05 18:41:21 +0000
4@@ -20,9 +20,9 @@
5 sso_urls = {'staging': 'https://loging.staging.ubuntu.com/',
6 'edge': 'https://loging.ubuntu.com/',
7 'production': 'https://loging.ubuntu.com/'}
8-files_urls = {'staging': 'https://staging.one.ubuntu.com/',
9- 'edge': 'https://edge.one.ubuntu.com/',
10- 'production': 'https://one.ubuntu.com/'}
11+files_urls = {'staging': 'https://files.staging.one.ubuntu.com/',
12+ 'edge': 'https://files.one.ubuntu.com/',
13+ 'production': 'https://files.one.ubuntu.com/'}
14
15 class Environment:
16

Subscribers

People subscribed via source and target branches