Ubuntu One Control Panel

Merge lp:~elopio/ubuntuone-control-panel/add-periods into lp:ubuntuone-control-panel

  1. add-periods
  2. Merge into trunk
Proposed by Leo Arias
Status: Rejected
Rejected by: Leo Arias
Proposed branch: lp:~elopio/ubuntuone-control-panel/add-periods
Merge into: lp:ubuntuone-control-panel
Diff against target: 37 lines (+4/-4)
2 files modified
data/gtk/services.ui (+3/-3)
ubuntuone/controlpanel/gui/__init__.py (+1/-1)
To merge this branch: bzr merge lp:~elopio/ubuntuone-control-panel/add-periods
Reviewer Review Type Date Requested Status
Leo Arias (community) Disapprove
Review via email: mp+81493@code.launchpad.net

Commit message

Add periods for consistency and to end sentences. (Fixes LP: #887300 and LP: #887301)

Description of the change

Add periods for consistency and to end sentences.
Fixes LP: #887300 and #887301

To post a comment you must log in.
Revision history for this message
Leo Arias (elopio) wrote :

From P and beyond we will just maintain the QT version of the control panel.

review: Disapprove

Unmerged revisions

239. By Leo Arias

Added periods to the sentences in the Services tab.

238. By Leo Arias

Added a period to the Cloud Folders title.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'data/gtk/services.ui'
2--- data/gtk/services.ui 2011-09-14 19:08:52 +0000
3+++ data/gtk/services.ui 2011-11-07 20:35:40 +0000
4@@ -94,9 +94,9 @@
5 <property name="can_focus">False</property>
6 <property name="xalign">0</property>
7 <property name="yalign">0</property>
8- <property name="label" translatable="yes">&lt;span font_size="small"&gt;Enable and then choose which folders you want to access from the Web or any device you connected to Ubuntu One
9+ <property name="label" translatable="yes">&lt;span font_size="small"&gt;Enable and then choose which folders you want to access from the Web or any device you connected to Ubuntu One.
10
11-Simply drag and drop any file or folder to your Ubuntu One folder on this computer&lt;/span&gt;</property>
12+Simply drag and drop any file or folder to your Ubuntu One folder on this computer.&lt;/span&gt;</property>
13 <property name="use_markup">True</property>
14 <property name="wrap">True</property>
15 <property name="width_chars">35</property>
16@@ -252,7 +252,7 @@
17 <property name="can_focus">True</property>
18 <property name="xalign">0</property>
19 <property name="yalign">0</property>
20- <property name="label" translatable="yes">&lt;span font_size="small"&gt;Once enabled, visit the &lt;a href="https://one.ubuntu.com"&gt;Ubuntu One website&lt;/a&gt; to manage your contacts, including Gmail and Facebook import&lt;/span&gt;</property>
21+ <property name="label" translatable="yes">&lt;span font_size="small"&gt;Once enabled, visit the &lt;a href="https://one.ubuntu.com"&gt;Ubuntu One website&lt;/a&gt; to manage your contacts, including Gmail and Facebook import.&lt;/span&gt;</property>
22 <property name="use_markup">True</property>
23 <property name="wrap">True</property>
24 </object>
25
26=== modified file 'ubuntuone/controlpanel/gui/__init__.py'
27--- ubuntuone/controlpanel/gui/__init__.py 2011-10-06 20:38:39 +0000
28+++ ubuntuone/controlpanel/gui/__init__.py 2011-11-07 20:35:40 +0000
29@@ -109,7 +109,7 @@
30 FOLDERS_BUTTON_TOOLTIP = VOLUMES_BUTTON_TOOLTIP = _('Manage your cloud '
31 'folders')
32 FOLDERS_TITLE = _('Select which folders from your cloud you want to sync with '
33- 'this computer')
34+ 'this computer.')
35 FILE_SYNC_CONNECT = _('Connect')
36 FILE_SYNC_CONNECT_TOOLTIP = _('Connect the file sync service with '
37 'your personal cloud')

Subscribers

People subscribed via source and target branches

to all changes: