Merge lp:~elopio/ubuntu-weather-app/autopilot-1.4 into lp:ubuntu-weather-app/obsolete.trunk

[Leo Arias]

Update tests for autopilot 1.4.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:156
http://91.189.93.70:8080/job/ubuntu-weather-app-ci/91/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/74
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-raring-amd64-ci/89
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-saucy-amd64-ci/89
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-weather-app-trusty-amd64-ci/3

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-weather-app-ci/91/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

It failed because "Couldn't load weather data". I'll retry the build.

Unmerged revisions

=== modified file 'debian/control'
--- debian/control	2013-08-15 15:52:32 +0000
+++ debian/control	2013-11-05 23:29:27 +0000
@@ -24,7 +24,7 @@
 Depends: ${misc:Depends},
          python2.7,
          ubuntu-weather-app (= ${source:Version}),
-         libautopilot-qt,
+         libautopilot-qt (>= 1.4),
          libqt5test5,
          libqt5widgets5,
          ubuntu-ui-toolkit-autopilot,

=== modified file 'tests/autopilot/ubuntu_weather_app/tests/test_locationmanager.py'
--- tests/autopilot/ubuntu_weather_app/tests/test_locationmanager.py	2013-10-07 07:26:30 +0000
+++ tests/autopilot/ubuntu_weather_app/tests/test_locationmanager.py	2013-11-05 23:29:27 +0000
@@ -354,4 +354,6 @@
         # count the tabs
         tabObjects = self.main_window.select_many('LocationTab', objectName='LocationTab')
         self.assertThat(lambda: number_of_locations, Eventually(Equals(len(tabObjects))))
-        self.assertThat(tabObjects[1].title, Eventually(Equals("Cairo")))
+        self.assertThat(
+            self.main_window.select_single('LocationTab', index=1).title,
+            Eventually(Equals("Cairo")))

=== modified file 'tests/autopilot/ubuntu_weather_app/tests/test_mainview.py'
--- tests/autopilot/ubuntu_weather_app/tests/test_mainview.py	2013-10-08 08:10:05 +0000
+++ tests/autopilot/ubuntu_weather_app/tests/test_mainview.py	2013-11-05 23:29:27 +0000
@@ -41,17 +41,20 @@
 
         # first tab should be visible after start
         tabs =  self.main_window.get_tabs()
-        tabObjects = self.main_window.select_many('LocationTab',objectName='LocationTab')
+        first_tab = self.main_window.select_single(
+            'LocationTab', index=0)
+        second_tab = self.main_window.select_single(
+            'LocationTab', index=1)
         self.assertThat(tabs.selectedTabIndex, Eventually(Equals(0)))
-        self.assertThat(tabObjects[0].visible, Eventually(Equals(True)))
-        self.assertThat(tabObjects[1].visible, Eventually(Equals(False)))
-        self.assertThat(tabObjects[0].title, Eventually(Equals("Hamburg")))
+        self.assertThat(first_tab.visible, Eventually(Equals(True)))
+        self.assertThat(second_tab.visible, Eventually(Equals(False)))
+        self.assertThat(first_tab.title, Eventually(Equals("Hamburg")))
         # switch to next tab
         self.main_window.switch_to_tab_by_index(1)
         self.assertThat(tabs.selectedTabIndex, Eventually(Equals(1)))
-        self.assertThat(tabObjects[0].visible, Eventually(Equals(False)))
-        self.assertThat(tabObjects[1].visible, Eventually(Equals(True)))
-        self.assertThat(tabObjects[1].title, Eventually(Equals("London")))
+        self.assertThat(first_tab.visible, Eventually(Equals(False)))
+        self.assertThat(second_tab.visible, Eventually(Equals(True)))
+        self.assertThat(second_tab.title, Eventually(Equals("London")))
 
     def test_refresh_tabs(self):
         # get the dates from the test data

=== modified file 'tests/autopilot/ubuntu_weather_app/tests/test_settings.py'
--- tests/autopilot/ubuntu_weather_app/tests/test_settings.py	2013-10-04 07:54:01 +0000
+++ tests/autopilot/ubuntu_weather_app/tests/test_settings.py	2013-11-05 23:29:27 +0000
@@ -38,18 +38,32 @@
     def _check_units(self, units):
         """Checks selected units by values from the first location tab"""
         self.assertThat(lambda: self.main_window.select_many('QQuickText', objectName='CurrentTempText'), Eventually(Not(Is(None))))
-        current_temps = self.main_window.select_many('QQuickText', objectName='CurrentTempText')
+        current_location_tab = self.main_window.select_single(
+            'LocationTab', visible=True)
+        today_item = current_location_tab.select_single(
+            'QQuickItem', focus=True)
+        today_temp = today_item.select_single(
+            'QQuickText', objectName='CurrentTempText')
+        tomorrow_item = today_item.get_parent().get_children_by_type(
+            'QQuickItem', focus=False, z=1)
+        tomorrow_temp = tomorrow_item[0].select_single(
+            'QQuickText', objectName='CurrentTempText')
         if units == "imperial":
-            self.assertThat(current_temps[0].text, Eventually(Equals(u'57')))
-            self.assertThat(current_temps[1].text, Eventually(Equals(u'69')))
+            self.assertThat(today_temp.text, Eventually(Equals(u'57')))
+            self.assertThat(tomorrow_temp.text, Eventually(Equals(u'69')))
         else:
-            self.assertThat(current_temps[0].text, Eventually(Equals(u'14')))
-            self.assertThat(current_temps[1].text, Eventually(Equals(u'21')))
+            self.assertThat(today_temp.text, Eventually(Equals(u'14')))
+            self.assertThat(tomorrow_temp.text, Eventually(Equals(u'21')))
 
     def _check_wind_units(self, wind_units):
         """Checks selected units by values from the first location tab"""
         self.assertThat(lambda: self.main_window.select_many('WeatherDetailComponent', objectName='WindSpeedValue')[0], Eventually(Not(Is(None))))
-        wind_component = self.main_window.select_many('WeatherDetailComponent', objectName='WindSpeedValue')[0]
+        current_location_tab = self.main_window.select_single(
+            'LocationTab', visible=True)
+        focused_item = current_location_tab.select_single(
+            'QQuickItem', focus=True)
+        wind_component = focused_item.select_single(
+            'WeatherDetailComponent', objectName='WindSpeedValue')
         self.assertThat(lambda: wind_component.select_single('QQuickText', objectName='WeatherDetailUnit'), Eventually(Not(Is(None))))
         wind_unit = wind_component.select_single('QQuickText', objectName='WeatherDetailUnit')
         self.assertThat(lambda: wind_component.select_single('QQuickText', objectName='WeatherDetailValue'), Eventually(Not(Is(None))))
@@ -64,7 +78,12 @@
     def _check_precipitation_units(self, pre_units):
         """Checks selected units by values from the first location tab"""
         self.assertThat(lambda: self.main_window.select_many('WeatherDetailComponent', objectName='PrecipitationValue')[0], Eventually(Not(Is(None))))
-        component = self.main_window.select_many('WeatherDetailComponent', objectName='PrecipitationValue')[0]
+        current_location_tab = self.main_window.select_single(
+            'LocationTab', visible=True)
+        focused_item = current_location_tab.select_single(
+            'QQuickItem', focus=True)
+        component = focused_item.select_single(
+            'WeatherDetailComponent', objectName='PrecipitationValue')
         self.assertThat(lambda: component.select_many('QQuickText', objectName='WeatherDetailUnit'), Eventually(Not(Is(None))))
         unit = component.select_single('QQuickText', objectName='WeatherDetailUnit')
         self.assertThat(lambda: component.select_single('QQuickText', objectName='WeatherDetailValue'), Eventually(Not(Is(None))))
@@ -117,7 +136,7 @@
         # click celsius option
         self._move_pointer_around()
         self.assertThat(lambda: units_selector.select_many('ShapeItem')[1], Eventually(Not(Is(None))))
-        metric_option = units_selector.select_many('ShapeItem')[1]
+        metric_option = units_selector.select_single('Label', text='Celsius')
         self.pointing_device.click_object(metric_option)
 
         # confirm
@@ -210,7 +229,8 @@
         # click kmh option
         self._move_pointer_around()
         self.assertThat(lambda: units_selector.select_many('ShapeItem')[1], Eventually(Not(Is(None))))
-        kmh_option = units_selector.select_many('ShapeItem')[1]
+        kmh_option = units_selector.select_single(
+            'Label', text='Kilometers per hour')
         self.pointing_device.click_object(kmh_option)
 
         # confirm
@@ -263,7 +283,9 @@
         # click mm option
         self._move_pointer_around()
         self.assertThat(lambda: units_selector.select_many('ShapeItem')[1], Eventually(Not(Is(None))))
-        mm_option = units_selector.select_many('ShapeItem')[1]
+        # XXX select the option by it's object name or index, using the
+        # emulator from the ubuntu-ui-toolkit.
+        mm_option = units_selector.select_single('Label', text='Millimeters')
         self.pointing_device.click_object(mm_option)
 
         # confirm