Merge lp:~elopio/ubuntu-ui-toolkit/tab_selection_timing into lp:ubuntu-ui-toolkit

[Leo Arias]

Improve the check of tab selection mode by moving to it first.

[Tim Peeters (tpeeters)]

Code looks good. Can you run the UITK, apps and unity8 autopilot tests to ensure nothing breaks?

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:969
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/1858/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/3780
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3368
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-amd64-ci/806
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/806
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/806/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3323
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3798
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/3798/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3370
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3370/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5739
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4618

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/1858/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:970
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/1913/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/4036
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/3621
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-amd64-ci/861
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/861
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-trusty-armhf-ci/861/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/3523
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4079
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/4079/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3623
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/3623/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/5949
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/4928

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-ui-toolkit-ci/1913/rebuild

review: Approve (continuous-integration)

[Leo Arias (elopio)]

Currently running ci@home on my mako. Will post the results when I wake up.

[Leo Arias (elopio)]

Results of ci@home: http://paste.ubuntu.com/7137015/

Failures:

ERROR: ubuntu_clock_app.tests.test_alarm.TestAlarm.test_toggle_alarm_status_must_enable_or_disable_alarm

Ran it 20 times afterwards, all of them passed. Unlikely to be affected by this branch, it might have been a weird glitch.

ERROR: dialer_app

The call button is not enabled.

FAIL: messaging_app

The send button is not enabled.

With those two, something must have go wrong with the way the kaleo's scripts install the image. I manually reflashed r254 and I can't reproduce those problems.

So I installed r250 and tests pass there. So this seems good to go. And the change is actually really small, it doesn't change any functionality, it just makes the trip to the tab bar more efficient.

[Tim Peeters (tpeeters)]

Only messaging-app failed for me: http://paste.ubuntu.com/7146603/
I don't know why

[Tim Peeters (tpeeters)]

on second try, the messaging-app tests fail again: http://paste.ubuntu.com/7146701/

[Tim Peeters (tpeeters)]

probably, because I had to do an apt-get update before I could install the autopilot tests, I was testing with mismatching versions of libs for messenger-app (or a broken version). Also, in image 256, messenger-app tests are broken. See https://bugs.launchpad.net/messaging-app/+bug/1296826

=== modified file 'tests/autopilot/ubuntuuitoolkit/emulators.py'
--- tests/autopilot/ubuntuuitoolkit/emulators.py	2014-03-03 08:37:42 +0000
+++ tests/autopilot/ubuntuuitoolkit/emulators.py	2014-03-18 15:24:41 +0000
@@ -346,6 +346,9 @@
         self.pointing_device.click_object(self._get_next_tab_button())
 
     def _activate_tab_bar(self):
+        # First move to the tab bar to avoid timing issues when we find it in
+        # selection mode but it's deselected while we move to it.
+        self.pointing_device.move_to_object(self)
         if self.selectionMode:
             logger.debug('Already in selection mode.')
         else: