Merge lp:~elopio/ubuntu-ui-toolkit/flake8 into lp:ubuntu-ui-toolkit
Proposed by
Leo Arias
Status: | Superseded |
---|---|
Proposed branch: | lp:~elopio/ubuntu-ui-toolkit/flake8 |
Merge into: | lp:ubuntu-ui-toolkit |
Diff against target: |
38 lines (+3/-3) 2 files modified
debian/control (+1/-1) debian/rules (+2/-2) |
To merge this branch: | bzr merge lp:~elopio/ubuntu-ui-toolkit/flake8 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot | continuous-integration | Approve | |
Ubuntu SDK team | Pending | ||
Review via email:
|
This proposal has been superseded by a proposal from 2014-04-11.
Commit message
Added a flake8 check when building the deb package.
Description of the change
Currently the static checks of the python code are done by pep8 and pyflakes in a script run by Jenkins.
Pyflakes doesn't let you ignore errors like imports unused, and we need them for the reorg in this branch: https:/
So as a prerequisite from that, we need to switch to flake8, which combines pep8 and pyflakes, and lets you ignore errors.
To post a comment you must log in.
PASSED: Continuous integration, rev:1008 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- ci/2023/ jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- trusty- touch/201 jenkins. qa.ubuntu. com/job/ generic- mediumtests- trusty/ 4778 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- trusty- amd64-ci/ 971 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- trusty- armhf-ci/ 971 jenkins. qa.ubuntu. com/job/ ubuntu- ui-toolkit- trusty- armhf-ci/ 971/artifact/ work/output/ *zip*/output. zip jenkins. qa.ubuntu. com/job/ generic- deb-autopilot- runner- mako/192 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- armhf/4359 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- armhf/4359/ artifact/ work/output/ *zip*/output. zip s-jenkins. ubuntu- ci:8080/ job/touch- flash-device/ 5942 jenkins. qa.ubuntu. com/job/ autopilot- testrunner- otto-trusty/ 4127 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- amd64/4910 jenkins. qa.ubuntu. com/job/ generic- mediumtests- builder- trusty- amd64/4910/ artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- ui-toolkit- ci/2023/ rebuild
http://