Merge lp:~elopio/ubuntu-ui-toolkit/flake8 into lp:ubuntu-ui-toolkit

Proposed by Leo Arias
Status: Superseded
Proposed branch: lp:~elopio/ubuntu-ui-toolkit/flake8
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 38 lines (+3/-3)
2 files modified
debian/control (+1/-1)
debian/rules (+2/-2)
To merge this branch: bzr merge lp:~elopio/ubuntu-ui-toolkit/flake8
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Ubuntu SDK team Pending
Review via email: mp+215339@code.launchpad.net

This proposal has been superseded by a proposal from 2014-04-11.

Commit message

Added a flake8 check when building the deb package.

Description of the change

Currently the static checks of the python code are done by pep8 and pyflakes in a script run by Jenkins.
Pyflakes doesn't let you ignore errors like imports unused, and we need them for the reorg in this branch: https://code.launchpad.net/~elopio/ubuntu-ui-toolkit/reorg_autopilot_helpers/+merge/215336
So as a prerequisite from that, we need to switch to flake8, which combines pep8 and pyflakes, and lets you ignore errors.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/control'
2--- debian/control 2014-03-17 09:02:58 +0000
3+++ debian/control 2014-04-11 03:31:02 +0000
4@@ -8,6 +8,7 @@
5 libglib2.0-dev,
6 python3,
7 python,
8+ python3-flake8,
9 libqt5qml-graphicaleffects | libqt5graphicaleffects5,
10 qt5-default,
11 qtbase5-dev,
12@@ -139,4 +140,3 @@
13 ubuntu-ui-toolkit-examples (>= ${source:Version}),
14 Description: Test package for Ubuntu UI Toolkit
15 Autopilot tests for the ubuntu-ui-toolkit package
16-
17
18=== modified file 'debian/rules'
19--- debian/rules 2014-03-27 08:59:19 +0000
20+++ debian/rules 2014-04-11 03:31:02 +0000
21@@ -9,6 +9,7 @@
22 dh $@ --fail-missing
23
24 override_dh_auto_test:
25+ flake8 tests/autopilot/ubuntuuitoolkit/
26 ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
27 mkdir -p debian/tmp/home/run
28 chmod +x tests/xvfb.sh
29@@ -20,8 +21,7 @@
30 dh_auto_build -- docs
31
32 override_dh_install:
33- mkdir -p debian/tmp/`qmake -query QT_INSTALL_DOCS`/qch
34+ mkdir -p debian/tmp/`qmake -query QT_INSTALL_DOCS`/qch
35 mkdir -p debian/tmp/usr/share/ubuntu-ui-toolkit/doc
36 cp -r $(CURDIR)/documentation/*qch debian/tmp/`qmake -query QT_INSTALL_DOCS`/qch
37 dh_install --fail-missing
38-

Subscribers

People subscribed via source and target branches

to status/vote changes: