Merge lp:~elopio/ubuntu-ui-toolkit/fix1211619-tab_loop into lp:ubuntu-ui-toolkit

[Leo Arias]

Added a safeguard to prevent the tabs autopilot emulator to loop for ever.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:693
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/508/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2197
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/365
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/365
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/365/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2203
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2203/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1867

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/508/rebuild

review: Approve (continuous-integration)

[Nicholas Skaggs (nskaggs)]

Thanks elopio ;-)

review: Approve

[lp:~elopio/ubuntu-ui-toolkit/fix1211619-tab_loop]

694. By Leo Arias on 2013-08-14

Renamed the number of switches var as suggested by Tim.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:694
http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-ci/515/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/2240
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-amd64-ci/372
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/372
        deb: http://jenkins.qa.ubuntu.com/job/ubuntu-ui-toolkit-saucy-armhf-ci/372/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2246
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/2246/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/1905

Click here to trigger a rebuild:
http://s-jenkins:8080/job/ubuntu-ui-toolkit-ci/515/rebuild

review: Approve (continuous-integration)

=== modified file 'tests/autopilot/ubuntuuitoolkit/emulators.py'
--- tests/autopilot/ubuntuuitoolkit/emulators.py	2013-08-09 09:56:18 +0000
+++ tests/autopilot/ubuntuuitoolkit/emulators.py	2013-08-14 14:30:40 +0000
@@ -20,6 +20,10 @@
 _NO_TABS_ERROR = 'The MainView has no Tabs.'
 
 
+class ToolkitEmulatorException(Exception):
+    """Exception raised when there is an error with the emulator."""
+
+
 def get_pointing_device():
     """Return the pointing device depending on the platform.
 
@@ -118,11 +122,19 @@
 
         """
         tabs = self.get_tabs()
-        if index >= tabs.get_number_of_tabs():
+        number_of_tabs = tabs.get_number_of_tabs()
+        if index >= number_of_tabs:
             raise IndexError('Tab index out of range.')
         current_tab = tabs.get_current_tab()
+        number_of_switches = 0
         while not tabs.selectedTabIndex == index:
+            if number_of_switches >= number_of_tabs - 1:
+                # This prevents a loop. But if this error is ever raised, it's
+                # likely there's a bug on the emulator or on the QML Tab.
+                raise ToolkitEmulatorException(
+                    'The tab with index {0} was not selected.'.format(index))
             current_tab = self.switch_to_next_tab()
+            number_of_switches += 1
         return current_tab
 
     def switch_to_previous_tab(self):