Merge lp:~elopio/ubuntu-filemanager-app/fix1201498-pyflakes into lp:ubuntu-filemanager-app

Proposed by Leo Arias
Status: Merged
Approved by: Michael Spencer
Approved revision: 51
Merged at revision: 48
Proposed branch: lp:~elopio/ubuntu-filemanager-app/fix1201498-pyflakes
Merge into: lp:ubuntu-filemanager-app
Diff against target: 35 lines (+2/-5)
2 files modified
tests/autopilot/ubuntu_filemanager_app/emulators/ubuntusdk.py (+0/-3)
tests/autopilot/ubuntu_filemanager_app/tests/test_filemanager.py (+2/-2)
To merge this branch: bzr merge lp:~elopio/ubuntu-filemanager-app/fix1201498-pyflakes
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Michael Spencer Approve
Review via email: mp+174818@code.launchpad.net

Commit message

Fixed the static errors.

To post a comment you must log in.
Revision history for this message
Michael Spencer (ibelieve) wrote :

Nice work, thanks!

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/ubuntu_filemanager_app/emulators/ubuntusdk.py'
2--- tests/autopilot/ubuntu_filemanager_app/emulators/ubuntusdk.py 2013-07-15 16:06:35 +0000
3+++ tests/autopilot/ubuntu_filemanager_app/emulators/ubuntusdk.py 2013-07-15 16:39:28 +0000
4@@ -16,9 +16,6 @@
5 #
6 # Authored by: Nicholas Skaggs <nicholas.skaggs@canonical.com>
7
8-from testtools.matchers import Equals, NotEquals, Not, Is
9-from autopilot.matchers import Eventually
10-
11
12 class ubuntusdk(object):
13 """An emulator class that makes it easy to interact with the ubuntu sdk
14
15=== modified file 'tests/autopilot/ubuntu_filemanager_app/tests/test_filemanager.py'
16--- tests/autopilot/ubuntu_filemanager_app/tests/test_filemanager.py 2013-07-15 16:12:53 +0000
17+++ tests/autopilot/ubuntu_filemanager_app/tests/test_filemanager.py 2013-07-15 16:39:28 +0000
18@@ -158,7 +158,7 @@
19 Equals(new_name)))
20
21 def test_delete_directory(self):
22- sub_dir = self._make_directory_in_home()
23+ self._make_directory_in_home()
24 first_folder = self.main_window.get_file_item(0)
25
26 self.tap_item(first_folder)
27@@ -178,7 +178,7 @@
28 self.assertThat(self.main_window.get_file_count, Eventually(Equals(0)))
29
30 def test_delete_file(self):
31- sub_dir = self._make_file_in_home()
32+ self._make_file_in_home()
33 first_folder = self.main_window.get_file_item(0)
34
35 self.tap_item(first_folder)

Subscribers

People subscribed via source and target branches