Merge lp:~elopio/ubuntu-clock-app/city-objectName into lp:ubuntu-clock-app/saucy

Proposed by Leo Arias
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 250
Merged at revision: 252
Proposed branch: lp:~elopio/ubuntu-clock-app/city-objectName
Merge into: lp:ubuntu-clock-app/saucy
Diff against target: 49 lines (+4/-2)
3 files modified
clock/ClockPage.qml (+1/-0)
clock/WorldClock.qml (+1/-0)
tests/autopilot/ubuntu_clock_app/tests/test_clock.py (+2/-2)
To merge this branch: bzr merge lp:~elopio/ubuntu-clock-app/city-objectName
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Nekhelesh Ramananthan Approve
Review via email: mp+192636@code.launchpad.net

Commit message

Add an objectName to the city labels.

To post a comment you must log in.
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

works as expected.Thanks for the test improvement.

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)
Revision history for this message
Leo Arias (elopio) wrote :

thanks to you for the review.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'clock/ClockPage.qml'
2--- clock/ClockPage.qml 2013-10-21 17:05:09 +0000
3+++ clock/ClockPage.qml 2013-10-25 04:34:53 +0000
4@@ -215,6 +215,7 @@
5 delegate: ListItem.Standard {
6 Label {
7 text: cityName
8+ objectName: "city_name"
9 anchors { verticalCenter: parent.verticalCenter; left: parent.left; leftMargin: units.gu(3) }
10 color: Theme.palette.normal.baseText
11 fontSize: "large"
12
13=== modified file 'clock/WorldClock.qml'
14--- clock/WorldClock.qml 2013-10-21 18:33:21 +0000
15+++ clock/WorldClock.qml 2013-10-25 04:34:53 +0000
16@@ -132,6 +132,7 @@
17 anchors { top: parent.top; topMargin: units.gu(0.5); left: parent.left; leftMargin: units.gu(3) }
18 Label {
19 id: cityDelegate
20+ objectName: "city_name"
21 text: city
22 color: Theme.palette.normal.baseText
23 fontSize: "large"
24
25=== modified file 'tests/autopilot/ubuntu_clock_app/tests/test_clock.py'
26--- tests/autopilot/ubuntu_clock_app/tests/test_clock.py 2013-10-17 00:59:35 +0000
27+++ tests/autopilot/ubuntu_clock_app/tests/test_clock.py 2013-10-25 04:34:53 +0000
28@@ -60,11 +60,11 @@
29 self.assert_no_cities_selected()
30 self.main_view.open_toolbar()
31 self.switch_to_world_cities_page()
32-
33 city = self.grab_first_city()
34 city_name = self.city_name_from(city)
35
36 self.select_city(city)
37+
38 selected_city_name = self.city_name_from(self.selected_city())
39 self.assertThat(selected_city_name, Eventually(Equals(city_name)))
40
41@@ -73,7 +73,7 @@
42 self.assert_no_cities_selected()
43
44 def city_name_from(self, city):
45- return city.select_many("Label")[0].text
46+ return city.select_single('Label', objectName='city_name').text
47
48 def enable_delete_button(self):
49 selected_city = self.selected_city()

Subscribers

People subscribed via source and target branches