Merge lp:~elopio/ubuntu-clock-app/check_alarm_creation into lp:ubuntu-clock-app/saucy

[Leo Arias]

Added waits for the alarms to be created or deleted.

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:358
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/301/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1540
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-raring-amd64-ci/301
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-saucy-amd64-ci/301
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-trusty-amd64-ci/219

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/301/rebuild

review: Approve (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:359
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/302/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1541
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-raring-amd64-ci/302
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-saucy-amd64-ci/302
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-trusty-amd64-ci/220

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/302/rebuild

review: Approve (continuous-integration)

[Nekhelesh Ramananthan (nik90)]

Do you mind reverting,

203 - city_name = self.add_local_world_city()
204 + self.add_local_world_city()

Since I did this in my MP https://code.launchpad.net/~nik90/ubuntu-clock-app/reorganise-clock-tests/+merge/208686. This way I wouldn't have to deal with conflicts ;)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

PASSED: Continuous integration, rev:360
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/303/
Executed test runs:
    SUCCESS: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1542
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-raring-amd64-ci/303
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-saucy-amd64-ci/303
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-trusty-amd64-ci/221

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/303/rebuild

review: Approve (continuous-integration)

[Nicholas Skaggs (nskaggs)]

Full run, including nik90's branch: http://paste.ubuntu.com/7007541/

[Nekhelesh Ramananthan (nik90)]

12:04 AM <nik90> balloons: I propose one thing that we can do about the situation of the 3 failures.
12:05 AM <nik90> balloons: 2 of them are random. I am unable to reproduce them on my computer
12:05 AM <nik90> balloons: the 3rd one (test_recurring_alarms) is a proper failure due to a bug in the clock app
12:06 AM <nik90> balloons: so can elopio create a new MP with just the fixes to the delete alarm test for today
12:06 AM <nik90> balloons: I will handle the clock app bug in the weekend and then propose along with the improved alarms tests copied from elopio's branch
12:07 AM <nik90> balloons: otherwise we will continue to have the delete alarm test failure in the image until I get the clock app bug fix.

[Nekhelesh Ramananthan (nik90)]

the 3rd failure is concerning the addition of recurring alarms...it seems that the clock app is not saving the alarms on all the days causing the test to fail

[Leo Arias (elopio)]

I've split the branch in two, as nik suggested. The other part is in https://code.launchpad.net/~elopio/ubuntu-clock-app/improve_alarm_tests/+merge/208714

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-clock-app-autolanding/143/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1545
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-raring-amd64-autolanding/143
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-saucy-amd64-autolanding/143
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-trusty-amd64-autolanding/79

review: Needs Fixing (continuous-integration)

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

FAILED: Continuous integration, rev:362
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/306/
Executed test runs:
    UNSTABLE: http://91.189.93.70:8080/job/generic-mediumtests-trusty/1546
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-raring-amd64-ci/306
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-saucy-amd64-ci/306
    SUCCESS: http://91.189.93.70:8080/job/ubuntu-clock-app-trusty-amd64-ci/224

Click here to trigger a rebuild:
http://91.189.93.70:8080/job/ubuntu-clock-app-ci/306/rebuild

review: Needs Fixing (continuous-integration)

[Leo Arias (elopio)]

This is a failure that happens some times on the clock tab, and nik fixed here: https://code.launchpad.net/~nik90/ubuntu-clock-app/reorganise-clock-tests/+merge/208686

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'tests/autopilot/ubuntu_clock_app/emulators.py'
--- tests/autopilot/ubuntu_clock_app/emulators.py	2014-02-27 20:45:11 +0000
+++ tests/autopilot/ubuntu_clock_app/emulators.py	2014-02-28 01:27:05 +0000
@@ -273,31 +273,23 @@
 
     def get_num_of_alarms(self):
         """Return the number of saved alarms."""
-        alarm_list = self.wait_select_single(
-            toolkit_emulators.QQuickListView,
-            objectName='listSavedAlarm')
-        #alarm_list.print_tree()
-        #sys.exit()
-        try:
-            print "Select single"
-            alarm_list.select_single('Base')
-            num_alarms = 1
-        except:
-            try:
-                print "Select many"
-                num_alarms = len(alarm_list.select_many('Base'))
-            except:
-                print "Select 0"
-                num_alarms = 0
-        print "num_alarms " + str(num_alarms)
-        return num_alarms
+        return int(self._get_saved_alarms_list().count)
+
+    def _get_saved_alarms_list(self):
+        return self.wait_select_single(
+            toolkit_emulators.QQuickListView,  objectName='listSavedAlarm')
 
     @autopilot_logging.log_action(logger.info)
     def add_alarm(self, name, alarm_type, day):
+        old_alarm_count = self.get_num_of_alarms()
         add_alarm_page = self._click_add_alarm_button()
         add_alarm_page.fill_alarm_info(name, alarm_type, day)
         self._click_save()
         self._wait_to_stop_moving()
+        try:
+            self._get_saved_alarms_list().count.wait_for(old_alarm_count + 1)
+        except AssertionError:
+            raise ClockEmulatorException('Error creating alarm.')
 
     def _click_add_alarm_button(self):
         """Click the add alarm toolbar button."""
@@ -313,12 +305,17 @@
     @autopilot_logging.log_action(logger.info)
     def delete_alarm(self, index):
         """Delete an alarm at the specified index."""
+        old_alarm_count = self.get_num_of_alarms()
         alarm = self.wait_select_single(
             toolkit_emulators.Base, objectName='alarm{}'.format(index))
         if not self.main_view.wideAspect:
             self.drag_page_up()
         alarm.swipe_to_delete()
         alarm.confirm_removal()
+        try:
+            self._get_saved_alarms_list().count.wait_for(old_alarm_count - 1)
+        except AssertionError:
+            raise ClockEmulatorException('Error deleting alarm.')
 
     @autopilot_logging.log_action(logger.info)
     def toggle_alarm(self, index):

=== modified file 'tests/autopilot/ubuntu_clock_app/tests/__init__.py'
--- tests/autopilot/ubuntu_clock_app/tests/__init__.py	2014-02-14 22:48:40 +0000
+++ tests/autopilot/ubuntu_clock_app/tests/__init__.py	2014-02-28 01:27:05 +0000
@@ -59,7 +59,7 @@
         #turn off the OSK so it doesn't block screen elements
         if model() != 'Desktop':
             os.system("stop maliit-server")
-            self.addCleanup(os.system,"start maliit-server")
+            self.addCleanup(os.system, "start maliit-server")
 
         if os.path.exists(self.local_location):
             self.launch_test_local()