Merge lp:~elopio/ubuntu-calculator-app/fix1210019-pep8 into lp:~ubuntu-calculator-dev/ubuntu-calculator-app/old_trunk

[Leo Arias]

Fixed the pep8 errors.

[Mihir Soni (mihirsoni)]

Hi ,

Line no 8 & 26 are unnecessary for this MR as it just do the indentation.

Could you please resubmit this MR

Thanks for fix !!

review: Needs Fixing

[Leo Arias (elopio)]

Hi Mihir,

According to pep8, we should "Separate top-level function and class definitions with two blank lines."
http://www.python.org/dev/peps/pep-0008/#blank-lines

That's the reason for those two lines.

[Riccardo Padovani (rpadovani)]

Thanks Leo, looks good to me!

review: Approve

[Mihir Soni (mihirsoni)]

> Hi Mihir,
>
> According to pep8, we should "Separate top-level function and class
> definitions with two blank lines."
> http://www.python.org/dev/peps/pep-0008/#blank-lines
>
> That's the reason for those two lines.

Okay understood :)

review: Approve

[Gustavo Pichorim Boiko (boiko)]

Looks good. Thanks for the changes!

review: Approve

[Leo Arias (elopio)]

Thanks for the reviews :)
Can you please mark the branch globally approved so it lands? I can't do it.
After it's on trunk, I'll ask fginther to enable the pep8 and pyflakes check on the landing bot.

[Leo Arias (elopio)]

oh, boiko just did it. Thanks!

[Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot)]

review: Approve (continuous-integration)

=== modified file 'images/generate.py'
--- images/generate.py	2013-07-18 20:19:42 +0000
+++ images/generate.py	2013-08-08 07:27:25 +0000
@@ -3,16 +3,22 @@
 import subprocess
 import os
 
+
 def main():
     for idx in range(8, 19):
         output_name = os.path.join('../Simple/images', 'edit@%d.png' % idx)
-        command = ['inkscape', '-f', 'edit.svg', '-e', output_name, '-w', str(idx*2)]
+        command = [
+            'inkscape', '-f', 'edit.svg', '-e', output_name, '-w', str(idx*2)
+        ]
         subprocess.call(command)
 
     for idx in range(8, 19):
         output_name = os.path.join('../Simple/images', 'dot@%d.png' % idx)
-        command = ['inkscape', '-f', 'dot.svg', '-e', output_name, '-w', str(idx)]
+        command = [
+            'inkscape', '-f', 'dot.svg', '-e', output_name, '-w', str(idx)
+        ]
         subprocess.call(command)
 
+
 if __name__ == '__main__':
     main()