Merge lp:~elopio/u1-test-utils/update-sso-dependencies into lp:u1-test-utils

Proposed by Leo Arias
Status: Merged
Approved by: Leo Arias
Approved revision: 93
Merged at revision: 85
Proposed branch: lp:~elopio/u1-test-utils/update-sso-dependencies
Merge into: lp:u1-test-utils
Diff against target: 83 lines (+14/-12)
5 files modified
setup_vm/sso/run (+6/-5)
setup_vm/sso/run-for-pay (+2/-1)
setup_vm/sso/run-for-u1 (+2/-1)
setup_vm/sso/test (+1/-3)
setup_vm/vms.conf (+3/-2)
To merge this branch: bzr merge lp:~elopio/u1-test-utils/update-sso-dependencies
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
Review via email: mp+173210@code.launchpad.net

Commit message

Update the installation of the SSO machine using the dependencies package.
Run the machine with the ubuntuone brand.

Description of the change

Following http://bazaar.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/trunk/revision/952 we can now install all the dependencies for SSO with a meta package.

To post a comment you must log in.
93. By Leo Arias

Last bits to make the run and run-for-pay more similar.

Revision history for this message
Vincent Ladeuil (vila) wrote :

Nice.

You may want to update your commit message to mention that you're also selecting the ubuntuone brand.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'setup_vm/sso/run'
2--- setup_vm/sso/run 2013-03-16 22:38:01 +0000
3+++ setup_vm/sso/run 2013-07-05 14:00:32 +0000
4@@ -5,12 +5,13 @@
5 .env/bin/twistd localmail --imap {sso.imap_port} --smtp {sso.smtp_port}
6
7 # Setup the database.
8+rm -fr .env/db # So this script can run more than once when needed
9 fab setup_postgresql_server
10 fab manage:loaddata,test
11 fab manage:create_test_team
12-# get gargoyle flags from their use in the code
13-SST_FLAGS=`grep -rho --exclude 'test_*.py' "is_active([\"']\(.*\)[\"']" identityprovider/ webui/ | sed -E "s/is_active\(['\"](.*)['\"]/\1/" | awk '{print tolower($0)}' | sort | uniq | tr '\n' ','`
14-# We need to remove the trailing ','
15-fab gargoyle_flags:${SST_FLAGS%,}
16+# add openid RP config
17+# we need this to explicitly allow unverified logins
18+fab manage:add_openid_rp_config,$SST_BASE_URL/consumer,--allow-unverified,--allowed-user-attribs="fullname\,nickname\,email\,language,account_verified"
19+fab manage:add_switch,"brand_ubuntuone"
20 # Start the SSO server, accessible from the local network.
21-fab run:0.0.0.0:{sso.port}
22+fab brand:ubuntuone run:0.0.0.0:{sso.port}
23
24=== modified file 'setup_vm/sso/run-for-pay'
25--- setup_vm/sso/run-for-pay 2013-05-11 15:23:33 +0000
26+++ setup_vm/sso/run-for-pay 2013-07-05 14:00:32 +0000
27@@ -5,10 +5,11 @@
28 .env/bin/twistd localmail --imap {sso.imap_port} --smtp {sso.smtp_port}
29
30 # Setup the database.
31+rm -fr .env/db # So this script can run more than once when needed
32 fab setup_postgresql_server
33 fab manage:loaddata,isdtest
34-fab manage:loaddata,allow_unverified
35 # Set the allow-unverified config for Pay.
36 fab manage:add_openid_rp_config,{pay.url},--allow-unverified,--allowed-user-attribs="fullname\,nickname\,email\,language"
37+fab manage:add_switch,"brand_ubuntuone"
38 # Start the SSO server, accessible from the local network.
39 fab run:0.0.0.0:{sso.port}
40
41=== modified file 'setup_vm/sso/run-for-u1'
42--- setup_vm/sso/run-for-u1 2013-06-11 17:45:39 +0000
43+++ setup_vm/sso/run-for-u1 2013-07-05 14:00:32 +0000
44@@ -40,5 +40,6 @@
45
46 EOF
47 fab manage:loaddata,apiuser
48+fab manage:add_switch,"brand_ubuntuone"
49 # Start the SSO server, accessible from the local network.
50-fab run:0.0.0.0:{sso.port}
51+fab brand:ubuntuone run:0.0.0.0:{sso.port}
52
53=== modified file 'setup_vm/sso/test'
54--- setup_vm/sso/test 2013-03-13 18:23:17 +0000
55+++ setup_vm/sso/test 2013-07-05 14:00:32 +0000
56@@ -5,7 +5,5 @@
57
58 cd {sso.src_dir}
59
60-# get gargoyle flags from their use in the code
61-SST_FLAGS=`grep -rho --exclude 'test_*.py' "is_active([\"']\(.*\)[\"']" identityprovider/ webui/ | sed -E "s/is_active\(['\"](.*)['\"]/\1/" | awk '{print tolower($0)}' | sort | uniq | tr '\n' ';'`
62 # run tests
63-SST_BASE_URL={sso.url} fab acceptance:screenshot=true,report=xml,extended=true,flags=$SST_FLAGS
64+SST_BASE_URL={sso.url} fab acceptance:screenshot=true,report=xml,headless=True
65\ No newline at end of file
66
67=== modified file 'setup_vm/vms.conf'
68--- setup_vm/vms.conf 2013-06-12 06:05:33 +0000
69+++ setup_vm/vms.conf 2013-07-05 14:00:32 +0000
70@@ -42,10 +42,11 @@
71 vm.name=sso
72 vm.release=precise
73 vm.backing=precise-server-pristine.qcow2
74-vm.packages=config-manager, fabric, libpq-dev, make, memcached, postgresql-plpython, python-m2crypto, python-dev, python-setuptools, python-virtualenv, swig, wget, libxml2-dev, libxslt1-dev
75+vm.apt_sources=deb http://ppa.launchpad.net/canonical-isd-hackers/dependencies/ubuntu {vm.release} main|F5410BE0
76+vm.packages=python-software-properties, canonical-identity-provider-dependencies, canonical-identity-provider-developer-dependencies
77 vm.ubuntu_script=sso/install
78 vm.update=True
79-vm.uploaded_scripts=sso/run, sso/run-for-pay, sso/run-for-u1
80+vm.uploaded_scripts=sso/run, sso/test, sso/run-for-pay, sso/run-for-u1
81
82 [pay]
83 vm.name=pay

Subscribers

People subscribed via source and target branches

to all changes: