u1-test-utils

Merge lp:~elopio/u1-test-utils/rollback_create_account into lp:u1-test-utils

  1. rollback_create_account
  2. Merge into trunk
Proposed by Leo Arias
Status: Merged
Approved by: Natalia Bidart
Approved revision: 76
Merged at revision: 76
Proposed branch: lp:~elopio/u1-test-utils/rollback_create_account
Merge into: lp:u1-test-utils
Diff against target: 13 lines (+2/-1)
1 file modified
u1testutils/sso/sst/pages.py (+2/-1)
To merge this branch: bzr merge lp:~elopio/u1-test-utils/rollback_create_account
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Review via email: mp+166832@code.launchpad.net

Commit message

Rolled back the action to click the create account button.

Description of the change

This was changed by Jonas to make it work with the new theme, but it's not
the right solution as it will fail for pay. It will try to go to the /+new_account page in the pay server, that doesn't exist.

The right solution is to make a different page for the new theme, and make the helper smart enough to know if it's in the old or the new one. I'm working on that.

To post a comment you must log in.
Revision history for this message
Natalia Bidart (nataliabidart) wrote :

Looks good!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'u1testutils/sso/sst/pages.py'
2--- u1testutils/sso/sst/pages.py 2013-05-31 04:28:53 +0000
3+++ u1testutils/sso/sst/pages.py 2013-05-31 15:39:37 +0000
4@@ -104,7 +104,8 @@
5 return CreateAccount()
6
7 def _click_create_new_account(self):
8- sst.actions.go_to('/+new_account')
9+ new_account_link = sst.actions.get_element(id='new-account-link')
10+ sst.actions.click_link(new_account_link)
11
12
13 class LogInFromRedirect(LogIn):

Subscribers

People subscribed via source and target branches

to all changes: