Merge lp:~elopio/u1-test-utils/improve_login_from_redirect_error_message into lp:u1-test-utils

[Leo Arias]

Added a suggestion for the most common cause of LogIn errors.

[lp:~elopio/u1-test-utils/improve_login_from_redirect_error_message]

64. By Leo Arias on 2013-05-06

Added the test for the suggestion.

65. By Leo Arias on 2013-05-06

Improved the suggestion condition.

[Natalia Bidart (nataliabidart)]

Looks good!

review: Approve

=== added file 'u1testutils/sso/selftests/unit/test_sst_helpers.py'
--- u1testutils/sso/selftests/unit/test_sst_helpers.py	1970-01-01 00:00:00 +0000
+++ u1testutils/sso/selftests/unit/test_sst_helpers.py	2013-05-06 21:32:27 +0000
@@ -0,0 +1,40 @@
+# Copyright 2013 Canonical Ltd.
+#
+# This program is free software: you can redistribute it and/or modify it
+# under the terms of the GNU Lesser General Public License version 3, as
+# published by the Free Software Foundation.
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranties of
+# MERCHANTABILITY, SATISFACTORY QUALITY, or FITNESS FOR A PARTICULAR
+# PURPOSE.  See the GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License along
+# with this program.  If not, see <http://www.gnu.org/licenses/
+
+import mock
+
+import u1testutils.logging
+from u1testutils.sso.sst import pages
+
+
+class LogInFromRedirectTestCase(u1testutils.logging.LogHandlerTestCase):
+
+    def test_site_without_rpconfig(self):
+        with mock.patch.object(pages.LogInFromRedirect, 'assert_page_is_open'):
+            page = pages.LogInFromRedirect()
+
+        with mock.patch('sst.actions.get_elements') as mock_elements:
+            mock_elements.return_value = []
+            headings2 = ['Log in to Ubuntu Single Sign On', 'Are you new?']
+            for heading in headings2:
+                mock_heading_element = mock.Mock()
+                mock_heading_element.text = heading
+                mock_elements.return_value.append(mock_heading_element)
+            with self.assertRaises(AssertionError):
+                page.assert_headings2()
+        self.assertLogLevelContains(
+            'ERROR',
+            'Please check that you are logging in from a server with '
+            'an rpconfig on SSO. Otherwise, the headings in the page '
+            'will not be the ones we expect.')

=== modified file 'u1testutils/sso/sst/pages.py'
--- u1testutils/sso/sst/pages.py	2013-05-01 14:56:05 +0000
+++ u1testutils/sso/sst/pages.py	2013-05-06 21:32:27 +0000
@@ -21,6 +21,9 @@
 from u1testutils.sst import log_action
 
 
+logger = logging.getLogger('User test')
+
+
 class LogIn(u1testutils.sst.Page):
     """Log in page of the Ubuntu Single Sign On website.
 
@@ -107,6 +110,26 @@
         self._click_create_new_account()
         return CreateAccountFromRedirect()
 
+    def assert_headings2(self):
+        """Assert the h2 elements of the page.
+
+        This method wraps the one from the parent class in order to log
+        suggestions about the most common environment errors that make it fail.
+
+        """
+        try:
+            super(LogInFromRedirect, self).assert_headings2()
+        except AssertionError:
+            heading2_without_rpconfig = 'Log in to Ubuntu Single Sign On'
+            if heading2_without_rpconfig in self._get_elements_text('h2'):
+                suggestion = (
+                    'Please check that you are logging in from a server with '
+                    'an rpconfig on SSO. Otherwise, the headings in the page '
+                    'will not be the ones we expect.'
+                )
+                logger.error(suggestion)
+            raise
+
 
 class PageWithAnonymousSubheader(u1testutils.sst.Page):