Merge lp:~elopio/u1-test-utils/fix1211818-CreateNewAccountTestCase into lp:u1-test-utils

Proposed by Leo Arias
Status: Merged
Approved by: Natalia Bidart
Approved revision: 94
Merged at revision: 94
Proposed branch: lp:~elopio/u1-test-utils/fix1211818-CreateNewAccountTestCase
Merge into: lp:u1-test-utils
Diff against target: 35 lines (+12/-4)
1 file modified
u1testutils/sso/selftests/acceptance/test_sst_helpers.py (+12/-4)
To merge this branch: bzr merge lp:~elopio/u1-test-utils/fix1211818-CreateNewAccountTestCase
Reviewer Review Type Date Requested Status
Natalia Bidart (community) Approve
Vincent Ladeuil (community) Approve
Review via email: mp+179942@code.launchpad.net

Commit message

Added text to the log in button and the create account link on the FakeSSOWebsite.

Description of the change

It seems like a newer version of Firefox interprets a button without a text in a different way than before.
In this case, the link was inside the button, so instead of the link action, the button action was executed.
Adding text to them makes the fake site clearer for manual inspection, and solves the structure problem.

To post a comment you must log in.
Revision history for this message
Vincent Ladeuil (vila) wrote :

Ha, browser upgrade led to failures... Pfew, I prefer that than trying to understand how such tests have landed ;)

Thanks !

review: Approve
Revision history for this message
Natalia Bidart (nataliabidart) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'u1testutils/sso/selftests/acceptance/test_sst_helpers.py'
2--- u1testutils/sso/selftests/acceptance/test_sst_helpers.py 2013-07-06 07:05:26 +0000
3+++ u1testutils/sso/selftests/acceptance/test_sst_helpers.py 2013-08-13 15:18:24 +0000
4@@ -46,9 +46,13 @@
5 method="get" >
6 <input id="id_email" type="email" />
7 <input id="id_password" type="password" />
8- <button data-qa-id="login_button" type="submit" />
9+ <button data-qa-id="login_button" type="submit">
10+ Log in
11+ </button>
12 </form>
13- <a href="{create_account_link}" data-qa-id="create_account_link" />
14+ <a href="{create_account_link}" data-qa-id="create_account_link">
15+ create account
16+ </a>
17 </html>
18 """
19 )
20@@ -92,9 +96,13 @@
21 method="get" >
22 <input id="id_email" type="email" />
23 <input id="id_password" type="password" />
24- <button data-qa-id="login_button" type="submit" />
25+ <button data-qa-id="login_button" type="submit">
26+ Log in
27+ </button>
28 </form>
29- <a href="{create_account_link}" data-qa-id="user_intention_create" />
30+ <a href="{create_account_link}" data-qa-id="user_intention_create">
31+ create account
32+ </a>
33 </html>
34 """
35 )

Subscribers

People subscribed via source and target branches

to all changes: