u1-test-utils

Merge lp:~elopio/u1-test-utils/fix1187467-select_all_teams into lp:u1-test-utils

  1. fix1187467-select_all_teams
  2. Merge into trunk
Proposed by Leo Arias
Status: Merged
Approved by: Ricardo Kirkner
Approved revision: 77
Merged at revision: 77
Proposed branch: lp:~elopio/u1-test-utils/fix1187467-select_all_teams
Merge into: lp:u1-test-utils
Diff against target: 20 lines (+3/-3)
1 file modified
u1testutils/sso/sst/pages.py (+3/-3)
To merge this branch: bzr merge lp:~elopio/u1-test-utils/fix1187467-select_all_teams
Reviewer Review Type Date Requested Status
Ricardo Kirkner (community) Approve
Review via email: mp+167334@code.launchpad.net

Commit message

On the decide page, select all the information checkboxes visible.

Description of the change

When there is more than one team, a checkbox per team is shown, and a checkbox to select all the teams. The current behavior is to just select the "all" checkbox, but when we do this with selenium, it fails to trigger the selection of the individual teams checkboxes. So, not all of them are selected.

To make this bullet proof, it would be better to make sure all the visible checkboxes are selected.

To post a comment you must log in.
Revision history for this message
Ricardo Kirkner (ricardokirkner) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'u1testutils/sso/sst/pages.py'
2--- u1testutils/sso/sst/pages.py 2013-05-31 15:36:42 +0000
3+++ u1testutils/sso/sst/pages.py 2013-06-04 16:26:26 +0000
4@@ -347,13 +347,13 @@
5 """
6 information_checkboxes = self._get_information_checkboxes()
7 for checkbox in information_checkboxes:
8- sst.actions.set_checkbox_value(checkbox, True)
9+ if checkbox.is_displayed():
10+ sst.actions.set_checkbox_value(checkbox, True)
11 return self
12
13 def _get_information_checkboxes(self):
14 return sst.actions.get_elements_by_css(
15- 'form[name="decideform"] > .info-items > .list > li > '
16- 'input[type="checkbox"]')
17+ '*[data-qa-id="info-items"] input[type="checkbox"]')
18
19 @log_action(logging.info)
20 def yes_sign_me_in(self):

Subscribers

People subscribed via source and target branches

to all changes: